Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: b...@packages.debian.org, sanv...@debian.org
Control: affects -1 + src:bart
[ Reason ]
This upload fixes Bug #1026061 FTBFS randomly in bullseye.
[ Impact ]
Anybody who try to build the package from source may find
that the package FTBFS unexpectedly.
[ Tests ]
I've tested the fixed package in the AWS instances where it
used to fail, and it does not fail anymore.
[ Risks ]
Very low risk, as the change merely increases the tolerance for
a floating point comparison in the tests. The program itself
does not really change.
[ Checklist ]
[X] *all* changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in (old)stable
[X] the issue is verified as fixed in unstable
[ Changes ]
See debdiff.
[ Other info ]
I'm going to upload the package after sending this report,
but I'll wait for approval before pushing changes to salsa.
diff -Nru bart-0.6.00/debian/changelog bart-0.6.00/debian/changelog
--- bart-0.6.00/debian/changelog 2020-09-21 16:16:16.000000000 +0200
+++ bart-0.6.00/debian/changelog 2024-05-07 23:05:00.000000000 +0200
@@ -1,3 +1,11 @@
+bart (0.6.00-3+deb11u1) bullseye; urgency=medium
+
+ * Team upload.
+ * Cherry-pick 0004-relax-failing-unit-test.patch from
+ release 0.7.00-1. Fixes FTBFS bug. Closes: #1026061.
+
+ -- Santiago Vila <sanv...@debian.org> Tue, 07 May 2024 23:05:00 +0200
+
bart (0.6.00-3) unstable; urgency=medium
* Team upload
diff -Nru bart-0.6.00/debian/patches/0004-relax-failing-unit-test.patch
bart-0.6.00/debian/patches/0004-relax-failing-unit-test.patch
--- bart-0.6.00/debian/patches/0004-relax-failing-unit-test.patch
1970-01-01 01:00:00.000000000 +0100
+++ bart-0.6.00/debian/patches/0004-relax-failing-unit-test.patch
2024-05-07 23:05:00.000000000 +0200
@@ -0,0 +1,21 @@
+From: Martin Uecker <martin.uec...@med.uni-goettingen.de>
+Date: Mon, 25 Oct 2021 18:59:03 +0200
+Subject: relax failing unit test
+
+---
+ utests/test_nufft.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/utests/test_nufft.c b/utests/test_nufft.c
+index ec02762..95b65c5 100644
+--- a/utests/test_nufft.c
++++ b/utests/test_nufft.c
+@@ -114,7 +114,7 @@ static bool test_nufft_adjoint(void)
+
+ debug_printf(DP_DEBUG1, "adjoint diff: %f\n", diff);
+
+- bool ret = (diff < 1.E-6f);
++ bool ret = (diff < 1.E-5f);
+
+ linop_free(op);
+
diff -Nru bart-0.6.00/debian/patches/series bart-0.6.00/debian/patches/series
--- bart-0.6.00/debian/patches/series 2020-09-21 16:16:16.000000000 +0200
+++ bart-0.6.00/debian/patches/series 2024-05-07 23:05:00.000000000 +0200
@@ -1,3 +1,4 @@
0001-makefile-change-for-compatibility-with-debian.patch
0002-remove-empty-directory.patch
0003-deactivate-ode-unit-tests.patch
+0004-relax-failing-unit-test.patch
