All --

::: Re: 1071007, ALL CONCERNED :::

I am associated with the upstream project.
This is a real bug. Discovered it some time last week. This seems to have
been introduced when we added the new pyproject file with a setuptools
backend.

For some unknown reason, the installed package would dump its files into
either the dist-packages/site-packages dir rather than a package-named
subdir, or it would for even more mysterious reasons dump the src files
into _both_ dirs at the same time. This behavior was present no matter the
install method -- whether pip, rpm, etc.

I have resolved this bug in upstream PR #2111 (below), with a switch from
setuptools to Poetry, among several other more minor tasks. This PR is
currently undergoing review, but I expect it to be merged shortly. Once
merged, the packager here can pull and repack (or they can patch to in the
interim).

https://github.com/sherlock-project/sherlock/pull/2111

::: FOR THE PKG MAINTAINER :::

Since Poetry doesn't support dynamic versioning in the same way setuptools
did, that part of the workflow has to change a bit once this PR is merged.

Dynamic versioning now occurs via `poetry build` with the
`poetry-version-plugin` plugin installed alongside. Since many automated
workflows rely on pip, you may need to adapt it slightly. Reference the
spec file here for an example of how I adapted the rpm build workflow for
this. L43 and L44 run a quick sed to fetch and populate the version number
from the __init__ as the single source of truth.

https://github.com/ppfeister/pkg/blob/3959a6ef6c8a2318ae183a8e5d85241eb8f756bf/sherlock/sherlock-project.spec

If you're able to use Poetry with plugins as part of your workflow, then
that change may be moot.

::: ALL /> :::

Feel free to reach out if you have any questions.

Reply via email to