#35448: test --debug-sql SQL formatting is applied to more than the query
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  Jae Hyuck
         Type:                       |  Sa
  Cleanup/optimization               |                   Status:  assigned
    Component:  Testing framework    |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1

Comment:

 I don't think we want any solution that involves parsing the output using
 regular expressions. That's too complicated. Why not format the SQL before
 it's added to the logging statement in `db/backends/utils.py`?

 (Incidentally, I'm working on a MongoDB backend for Django and would like
 to override the formatting since it won't be SQL. If the formatting were
 done there, I could move the formatting to an overridable
 `DatabaseOperations.format_sql()` hook.)
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35448#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f77c180d0-ed8e61e6-0972-47c9-9e74-bc3111f4f601-000000%40eu-central-1.amazonses.com.

Reply via email to