https://bugs.kde.org/show_bug.cgi?id=483582

Christoph Cullmann <cullm...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kjobwidgets/-/commit
                   |                            |/6f3496ce99d5cb9e4ce561d0bf
                   |                            |c3b703fe9eec24

--- Comment #3 from Christoph Cullmann <cullm...@kde.org> ---
Git commit 6f3496ce99d5cb9e4ce561d0bfc3b703fe9eec24 by Christoph Cullmann, on
behalf of Méven Car.
Committed on 07/05/2024 at 19:28.
Pushed by cullmann into branch 'master'.

KUiServerV2JobTracker: prevent a crash
Related: bug 471531

This is a very-common crash, happening when plasma crashes itself:
https://crash-reports.kde.org/organizations/kde/issues/10390/activity/?project=4&query=is%3Aunresolved&referrer=issue-stream&stream_index=0

I think this is due to the line 204 indeed, dereferencing a jobViews key, which
is nullptr, because the `QTimer::timeout` callback in
`KUiServerV2JobTracker::registerJob` did implicitely insert a jobViews[nullptr]
when the job was already removed. Guard with jobGuard.
The first change is not necessary but I felt it makes the code implicit,
otherwise we have a QPointer implicit conversion to `*`.

cc @broulik

M  +5    -6    src/kuiserverv2jobtracker.cpp

https://invent.kde.org/frameworks/kjobwidgets/-/commit/6f3496ce99d5cb9e4ce561d0bfc3b703fe9eec24

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to