JacquesLeRoux commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615193
Hi, About the error above where git diff did not give any information ``` error: applications/marketing/data/MarketingPortletData.xml: already exists in working directory C:\projectsASF\Git\ofbiz-framework>git diff C:\projectsASF\Git\ofbiz-framework> ``` I know now what happened. As I said > The patch does no apply in Elipse nor with git apply I actually tried with Eclipse before and did not notice that MarketingPortletData.xml was already there but not added. Now we have > C:\projectsASF\Git\ofbiz-framework>git apply 785.patch > 785.patch:70: trailing whitespace. > <PortalPage portalPageId="marketing_MAIN" portalPageName="Marketing Main Page" > 785.patch:71: trailing whitespace. > description="The main portal page of the marketing application" > warning: 2 lines add whitespace errors. > You can neglect, it's OK (new lines, no trailing whitespaces) About ``` - <view-map name="main" type="screen" page="component://marketing/widget/CommonScreens.xml#main"/> + <view-map name="main" type="screen" page="component://marketing/widget/CommonScreens.xml#Main"/> - <screen name="main"> + <screen name="Main"> ``` Not needed. In current code 29 `<screen name="main">` vs 7 `<screen name="Main">` But maybe simple for you, not a pb finally. More important is this Typo (N/M) `<entity-resource type="data" reader-name="seed" loader="main" location="data/NarketingPortletData.xml"/>` You see that's the brittle of portals. I also remember a space at head of a portal reference not bing easy to find. Anyway tests are OK and I agree it's a good improvement. Though that could have been done with no new data in DB, isn't? I'll fix the typo and push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
