hvanhovell commented on code in PR #46575:
URL: https://github.com/apache/spark/pull/46575#discussion_r1600102948
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala:
##########
@@ -209,7 +209,8 @@ object AgnosticEncoders {
// Nullable leaf encoders
case object NullEncoder extends LeafEncoder[java.lang.Void](NullType)
- case object StringEncoder extends LeafEncoder[String](StringType)
+ class StringEncoder(strType: DataType) extends LeafEncoder[String](strType)
Review Comment:
Eensy teensy tiny nit. We can create an instance per string dataType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
