itholic commented on code in PR #46602:
URL: https://github.com/apache/spark/pull/46602#discussion_r1602388729
##########
python/pyspark/pandas/frame.py:
##########
@@ -491,7 +491,8 @@ class DataFrame(Frame, Generic[T]):
>>> import pandas as pd
>>> sdf = spark.createDataFrame([("Data", 1), ("Bricks", 2)], ["x", "y"])
- >>> ps.DataFrame(data=sdf, index=pd.Index([0, 1, 2]))
+ >>> with ps.option_context("compute.ops_on_diff_frames", False):
+ ... ps.DataFrame(data=sdf, index=pd.Index([0, 1, 2]))
Review Comment:
I think maybe now we can just remove the negative cases from the doctests
and keep only UTs??
##########
python/pyspark/pandas/frame.py:
##########
@@ -509,7 +510,8 @@ class DataFrame(Frame, Generic[T]):
>>> import pandas as pd
>>> sdf = spark.createDataFrame([("Data", 1), ("Bricks", 2)], ["x", "y"])
- >>> ps.DataFrame(data=sdf, index=ps.Index([0, 1, 2]))
+ >>> with ps.option_context("compute.ops_on_diff_frames", False):
+ ... ps.DataFrame(data=sdf, index=ps.Index([0, 1, 2]))
Review Comment:
ditto and all belows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
