dbatomic commented on code in PR #46180:
URL: https://github.com/apache/spark/pull/46180#discussion_r1604917892
##########
connector/connect/common/src/main/protobuf/spark/connect/types.proto:
##########
@@ -101,7 +101,7 @@ message DataType {
message String {
uint32 type_variation_reference = 1;
- uint32 collation_id = 2;
+ string collation = 2;
Review Comment:
And it makes sense. Collation id should be internal spark concept. Outside
of spark you should always use collation name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
