Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2024-05-09 Thread via GitHub


panbingkun commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1595341865


##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('*').show()
++---+-+
+|age| name|
++---+-+
+|  2|Alice|
+|  5|  Bob|
++---+-+
+
+
+Select by column names(string) or expressions (:class:`Column`)
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('name', (df.age + 10).alias('age')).show()
++-+---+
+| name|age|
++-+---+
+|Alice| 12|
+|  Bob| 15|
++-+---+
+
+
+Filter
+--
+
+Filters rows using the given condition.
+For more detailed usage methods, please refer to :meth:`DataFrame.filter`.
+
+Filter by :class:`Column` instances
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice", "Math"), (5, "Bob", 
"Physics"),
+... (7, "Charlie", "Chemistry")], schema=["age", "name", "subject"])
+>>> df.filter(df.age > 3).show()
++---+---+-+
+|age|   name|  subject|
++---+---+-+
+|  5|Bob|  Physics|
+|  7|Charlie|Chemistry|
++---+---+-+
+
+
+Filter by SQL expression in a string
+
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice", "Math"), (5, "Bob", 
"Physics"), (7, "Charlie", "Chemistry")],
+... schema=["age", "name", "subject"])
+>>> df.filter("age > 3").show()
++---+---+-+
+|age|   name|  subject|
++---+---+-+
+|  5|Bob|  Physics|
+|  7|Charlie|Chemistry|
++---+---+-+
+
+
+Collect
+---
+
+Returns all the records in the DataFrame as a list of :class:`Row`.
+For more detailed usage methods, please refer to :meth:`DataFrame.collect`.
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(14, "Tom"), (23, "Alice"), (16, "Bob")], 
["age", "name"])
+>>> df.collect()
+[Row(age=14, name='Tom'), Row(age=23, name='Alice'), Row(age=16, 
name='Bob')]
+

Review Comment:
   I'll update it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2024-05-08 Thread via GitHub


srchilukoori commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1594759835


##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('*').show()
++---+-+
+|age| name|
++---+-+
+|  2|Alice|
+|  5|  Bob|
++---+-+
+
+
+Select by column names(string) or expressions (:class:`Column`)
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('name', (df.age + 10).alias('age')).show()
++-+---+
+| name|age|
++-+---+
+|Alice| 12|
+|  Bob| 15|
++-+---+
+
+
+Filter
+--
+
+Filters rows using the given condition.
+For more detailed usage methods, please refer to :meth:`DataFrame.filter`.
+
+Filter by :class:`Column` instances
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice", "Math"), (5, "Bob", 
"Physics"),
+... (7, "Charlie", "Chemistry")], schema=["age", "name", "subject"])
+>>> df.filter(df.age > 3).show()
++---+---+-+
+|age|   name|  subject|
++---+---+-+
+|  5|Bob|  Physics|
+|  7|Charlie|Chemistry|
++---+---+-+
+
+
+Filter by SQL expression in a string
+
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice", "Math"), (5, "Bob", 
"Physics"), (7, "Charlie", "Chemistry")],
+... schema=["age", "name", "subject"])
+>>> df.filter("age > 3").show()
++---+---+-+
+|age|   name|  subject|
++---+---+-+
+|  5|Bob|  Physics|
+|  7|Charlie|Chemistry|
++---+---+-+
+
+
+Collect
+---
+
+Returns all the records in the DataFrame as a list of :class:`Row`.
+For more detailed usage methods, please refer to :meth:`DataFrame.collect`.
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(14, "Tom"), (23, "Alice"), (16, "Bob")], 
["age", "name"])
+>>> df.collect()
+[Row(age=14, name='Tom'), Row(age=23, name='Alice'), Row(age=16, 
name='Bob')]
+

Review Comment:
   @panbingkun Could you add a warning for this function as well. Since collect 
pulls the data into the driver and has a potential to kill it if the dataset is 
large.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2024-05-08 Thread via GitHub


srchilukoori commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1594753548


##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('*').show()
++---+-+
+|age| name|
++---+-+
+|  2|Alice|
+|  5|  Bob|
++---+-+
+
+
+Select by column names(string) or expressions (:class:`Column`)
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('name', (df.age + 10).alias('age')).show()

Review Comment:
   @panbingkun If the user is interested in selecting all available columns, 
wouldn't `df.show()` be a better option?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2024-02-23 Thread via GitHub


xinrong-meng commented on PR #43972:
URL: https://github.com/apache/spark/pull/43972#issuecomment-1961882413

   Thank you for working on that guide, that's very helpful!
   
   Out of curiosity, how do we decide which operations are "basic"? For 
example, why is "head" excluded?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-12-29 Thread via GitHub


nchammas commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1438476161


##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('*').show()
++---+-+
+|age| name|
++---+-+
+|  2|Alice|
+|  5|  Bob|
++---+-+
+
+
+Select by column names(string) or expressions (:class:`Column`)
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('name', (df.age + 10).alias('age')).show()

Review Comment:
   In fact, I think it's important to use the `__getitem__` syntax as the 
preferred syntax in these guides, in order to be consistent with the 
recommendation provided in the "Getting Started" guide: 
https://github.com/apache/spark/blob/af3a22533ca0a11d91cc70c920d5423a8dac9ee5/docs/sql-getting-started.md?plain=1#L120-L124



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-12-14 Thread via GitHub


panbingkun commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1426598473


##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('*').show()
++---+-+
+|age| name|
++---+-+
+|  2|Alice|
+|  5|  Bob|
++---+-+
+
+
+Select by column names(string) or expressions (:class:`Column`)
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('name', (df.age + 10).alias('age')).show()

Review Comment:
   Okay, I will add an example based on `df["age"]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-12-13 Thread via GitHub


nchammas commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1426079059


##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])

Review Comment:
   It's not a big deal, but note that the method you used here to specify the 
schema is not among the methods you demonstrated [over on 
#43897](https://github.com/apache/spark/pull/43897/files#diff-305f8ba2839b0d1db701f7c024c1c8fe3ec6d6e338dc2ba44a1d27780a361976R44).
 (I personally prefer this method here most of the time because Spark typically 
infers the schema correctly.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-12-13 Thread via GitHub


nchammas commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1426079059


##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])

Review Comment:
   It's not a big deal, but note that the method you used here to specify the 
schema is not among the methods you demonstrated [over on 
#43897](https://github.com/apache/spark/pull/43897/files#diff-305f8ba2839b0d1db701f7c024c1c8fe3ec6d6e338dc2ba44a1d27780a361976R44).



##
python/docs/source/user_guide/basic_dataframe_operations.rst:
##
@@ -0,0 +1,169 @@
+..  Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+..http://www.apache.org/licenses/LICENSE-2.0
+
+..  Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+==
+Basic DataFrame Operations
+==
+
+.. currentmodule:: pyspark.sql
+
+Select
+--
+
+Projects a set of expressions and returns a new :class:`DataFrame`.
+For more detailed usage methods, please refer to :meth:`DataFrame.select`.
+
+Select all columns
+~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('*').show()
++---+-+
+|age| name|
++---+-+
+|  2|Alice|
+|  5|  Bob|
++---+-+
+
+
+Select by column names(string) or expressions (:class:`Column`)
+~~~
+
+.. code-block:: python
+
+>>> df = spark.createDataFrame([(2, "Alice"), (5, "Bob")], schema=["age", 
"name"])
+>>> df.select('name', (df.age + 10).alias('age')).show()

Review Comment:
   A minor point, but should we mention or demonstrate somehow that you can 
also select columns using the `__getitem__` syntax (`df["age"]`) in addition to 
the `__getattr__` syntax (`df.age`) demonstrated here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-11-28 Thread via GitHub


HyukjinKwon commented on PR #43972:
URL: https://github.com/apache/spark/pull/43972#issuecomment-1831003059

   cc @allanf-db FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-11-23 Thread via GitHub


panbingkun commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1403810833


##
python/docs/source/user_guide/index.rst:
##
@@ -26,6 +26,7 @@ PySpark specific user guides are available here:
:maxdepth: 2
 
python_packaging
+   basic_dataframe_operations

Review Comment:
   Okay



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-11-23 Thread via GitHub


HyukjinKwon commented on code in PR #43972:
URL: https://github.com/apache/spark/pull/43972#discussion_r1403787346


##
python/docs/source/user_guide/index.rst:
##
@@ -26,6 +26,7 @@ PySpark specific user guides are available here:
:maxdepth: 2
 
python_packaging
+   basic_dataframe_operations

Review Comment:
   We should probably put this under `sql/index` (and probably rename from 
`Spark SQL` -> sth like `DataFrame and SQL`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-45862][PYTHON][DOCS] Add user guide for basic dataframe operations [spark]

2023-11-22 Thread via GitHub


panbingkun commented on PR #43972:
URL: https://github.com/apache/spark/pull/43972#issuecomment-1823891634

   After it:
   https://github.com/apache/spark/assets/15246973/76d667a2-07b2-4770-8631-6270c3ec70de;>
   https://github.com/apache/spark/assets/15246973/93056ebb-ba94-451b-ac5e-a21027438138;>
   https://github.com/apache/spark/assets/15246973/50af9cbb-d144-499f-bd54-1164c416135a;>
   https://github.com/apache/spark/assets/15246973/97e813a2-1aee-4b6a-8261-38d559f3c909;>
   https://github.com/apache/spark/assets/15246973/3f87d1ce-e090-4cae-82bf-f0da1e5b49e1;>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org