Re: [PR] [SPARK-48126][Core] Make `spark.log.structuredLogging.enabled` effective [spark]

2024-05-07 Thread via GitHub


gengliangwang closed pull request #46452: [SPARK-48126][Core] Make 
`spark.log.structuredLogging.enabled` effective
URL: https://github.com/apache/spark/pull/46452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48126][Core] Make `spark.log.structuredLogging.enabled` effective [spark]

2024-05-07 Thread via GitHub


gengliangwang commented on PR #46452:
URL: https://github.com/apache/spark/pull/46452#issuecomment-2099603466

   @dongjoon-hyun @HyukjinKwon Thanks for the review. I am merging this one to 
master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48126][Core] Make `spark.log.structuredLogging.enabled` effective [spark]

2024-05-07 Thread via GitHub


gengliangwang commented on PR #46452:
URL: https://github.com/apache/spark/pull/46452#issuecomment-2099482455

   > Since this PR doesn't have any test coverage, could you elaborate more 
specifically in the PR description when this doesn't work?
   
   You are right. I just updated the description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48126][Core] Make `spark.log.structuredLogging.enabled` effective [spark]

2024-05-07 Thread via GitHub


gengliangwang commented on PR #46452:
URL: https://github.com/apache/spark/pull/46452#issuecomment-2099472878

   cc @panbingkun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org