Re: [PR] [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources [spark]
allisonwang-db commented on code in PR #46487: URL: https://github.com/apache/spark/pull/46487#discussion_r1597284865 ## sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -234,7 +234,7 @@ class SparkSession private( /** * A collection of methods for registering user-defined data sources. */ - private[sql] def dataSource: DataSourceRegistration = sessionState.dataSourceRegistration Review Comment: Will do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources [spark]
HyukjinKwon commented on code in PR #46487: URL: https://github.com/apache/spark/pull/46487#discussion_r1594808251 ## sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -234,7 +234,7 @@ class SparkSession private( /** * A collection of methods for registering user-defined data sources. */ - private[sql] def dataSource: DataSourceRegistration = sessionState.dataSourceRegistration Review Comment: oh yeah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources [spark]
dongjoon-hyun commented on code in PR #46487: URL: https://github.com/apache/spark/pull/46487#discussion_r1594806040 ## sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -234,7 +234,7 @@ class SparkSession private( /** * A collection of methods for registering user-defined data sources. */ - private[sql] def dataSource: DataSourceRegistration = sessionState.dataSourceRegistration Review Comment: Also, please set appropriate tags like the following. ``` @Experimental @Unstable ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources [spark]
dongjoon-hyun commented on code in PR #46487: URL: https://github.com/apache/spark/pull/46487#discussion_r1594805542 ## sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -234,7 +234,7 @@ class SparkSession private( /** * A collection of methods for registering user-defined data sources. */ - private[sql] def dataSource: DataSourceRegistration = sessionState.dataSourceRegistration Review Comment: Could you add `@since` tag because we open this, @allisonwang-db ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources [spark]
HyukjinKwon closed pull request #46487: [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources URL: https://github.com/apache/spark/pull/46487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources [spark]
HyukjinKwon commented on PR #46487: URL: https://github.com/apache/spark/pull/46487#issuecomment-2101653716 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48205][PYTHON] Remove the private[sql] modifier for Python data sources [spark]
allisonwang-db commented on PR #46487: URL: https://github.com/apache/spark/pull/46487#issuecomment-2101538253 cc @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
