[Bug 1705704]
(In reply to Tuomas Nurmi from comment #3) > Git commit 25b763728031b9737f8dce80653086fb0a05e3fc by Tuomas Nurmi. > Committed on 06/05/2024 at 15:14. > Pushed by nurmi into branch 'master'. > > Prevent crash in APG when constraint is missing data > > I'm not familliar enough with APG to properly assess if the fact noted on the > bug report, that amarok allows to generate an incomplete constraint, should > be > fixed or not, but at least it shouldn't crash. So let's fix that. > > M +2-2ChangeLog > M +2-0src/playlistgenerator/constraints/Checkpoint.cpp > > https://invent.kde.org/multimedia/amarok/-/commit/ > 25b763728031b9737f8dce80653086fb0a05e3fc Return 1.0 as the value in line 212. If the user hasn't specified a track for the checkpoint, then the logical behavior is that any track will satisfy the constraint. So the APG solver will work better if the constraint always reports that it's 100% satisfied when the track is unspecified. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1705704]
Sounds good, makes sense. Change committed in https://invent.kde.org/multimedia/amarok/-/commit/aad011a2ab722fd363870e7aa502e1663bee33bc - thank you for the comment! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1705704] Re: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint
** Changed in: amarok Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1705704]
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/amarok/-/merge_requests/94 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1705704]
Git commit 25b763728031b9737f8dce80653086fb0a05e3fc by Tuomas Nurmi. Committed on 06/05/2024 at 15:14. Pushed by nurmi into branch 'master'. Prevent crash in APG when constraint is missing data I'm not familliar enough with APG to properly assess if the fact noted on the bug report, that amarok allows to generate an incomplete constraint, should be fixed or not, but at least it shouldn't crash. So let's fix that. M +2-2ChangeLog M +2-0src/playlistgenerator/constraints/Checkpoint.cpp https://invent.kde.org/multimedia/amarok/-/commit/25b763728031b9737f8dce80653086fb0a05e3fc -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1705704] Re: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint
Launchpad has imported 2 comments from the remote bug at https://bugs.kde.org/show_bug.cgi?id=382456. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2017-07-18T08:05:31+00:00 P wrote: Created attachment 106703 the apl model with empty checkpoint condition that crashes amarok amarok allows me to generate an incomplete model of APL using an incomplete "checkpoint" constraint. to reproduce start with for example this APL model : pascal@minipc:~$ cat Musique/classiques3.xml then just add a "checkpoint" constraint to the constrainttree (see screenshot) but do not select anything as checkpoint parameters, just adjust strictness of checkpoint to exact click OK the new model is saved when editing this model you see the 2 constraints are there as in the screenshot but when exporting this model to a file the "checkpoint" constraint is absent ! now try to execute this model ==> amarok crashes running in debug mode gives this upon executing this incomplete model : pascal@minipc:~$ amarok: [APG::ConstraintSolver] New ConstraintSolver with serial number 967666005 amarok: [APG::ConstraintNode] new constraint node at 0x31de3f90 with parent at 0x2f6023f0 amarok: [APG::ConstraintSolver] Domain has 4376 tracks amarok: [APG::ConstraintSolver] Running ConstraintSolver 967666005 amarok: Fatal IO error: client killed Unable to start Dr. Konqi Not forwarding the crash to Apport. Reply at: https://bugs.launchpad.net/ubuntu/+source/amarok/+bug/1705704/comments/0 On 2024-04-23T20:20:11+00:00 Tuomas-1 wrote: Reproducible with 2.9.82. Let's see if I'll come up with a fix sometime Reply at: https://bugs.launchpad.net/ubuntu/+source/amarok/+bug/1705704/comments/3 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1705704] Re: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint
** Changed in: amarok Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1705704] [NEW] Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint
Public bug reported: amarok allows me to generate an incomplete model of APL using an incomplete "checkpoint" constraint. to reproduce start with for example this APL model : pascal@minipc:~$ cat Musique/classiques3.xml then just add a "checkpoint" constraint to the constrainttree (see screenshot) but do not select anything as checkpoint parameters, just adjust strictness of checkpoint to exact click OK the new model is saved when editing this model you see the 2 constraints are there as in the screenshot but when exporting this model to a file the "checkpoint" constraint is absent ! now try to execute this model ==> amarok crashes running in debug mode gives this upon executing this incomplete model : pascal@minipc:~$ amarok: [APG::ConstraintSolver] New ConstraintSolver with serial number 967666005 amarok: [APG::ConstraintNode] new constraint node at 0x31de3f90 with parent at 0x2f6023f0 amarok: [APG::ConstraintSolver] Domain has 4376 tracks amarok: [APG::ConstraintSolver] Running ConstraintSolver 967666005 amarok: Fatal IO error: client killed Unable to start Dr. Konqi Not forwarding the crash to Apport. ProblemType: Bug DistroRelease: Ubuntu 17.04 Package: amarok 2:2.8.0-0ubuntu9 ProcVersionSignature: Ubuntu 4.10.0-26.30-lowlatency 4.10.17 Uname: Linux 4.10.0-26-lowlatency x86_64 ApportVersion: 2.20.4-0ubuntu4.5 Architecture: amd64 CurrentDesktop: KDE Date: Fri Jul 21 15:18:23 2017 InstallationDate: Installed on 2016-05-14 (432 days ago) InstallationMedia: Kubuntu 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.1) SourcePackage: amarok UpgradeStatus: No upgrade log present (probably fresh install) ** Affects: amarok Importance: Unknown Status: Unknown ** Affects: amarok (Ubuntu) Importance: Undecided Status: New ** Tags: amd64 apport-bug third-party-packages zesty ** Bug watch added: KDE Bug Tracking System #382456 https://bugs.kde.org/show_bug.cgi?id=382456 ** Also affects: amarok via https://bugs.kde.org/show_bug.cgi?id=382456 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1705704 Title: Amarok APG: crashes if checkpoint is unassigned in CheckpointConstraint To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/1705704/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
