stschikin closed pull request #793: Fixed: PartyTypeAttr correction
(OFBIZ-13076)
URL: https://github.com/apache/ofbiz-framework/pull/793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
JacquesLeRoux commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104502150
Thanks for the clarification @stschikin
Please close your PR, TIA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
stschikin commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104298510
After re-evaluating the entire pull request, it looks like I have confused
TypeAttr entities with Attribute entities. Attribute entities need a AttrValue,
but TypeAttr do not.
JacquesLeRoux commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095961995
Yes, we finally can keep it. A party has only one type, but a party type may
have several attributes, hence several relations with a party.
--
This is an automated message
stschikin commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095786293
The relation to Party seems kind of redundant with the relation to
PartyType. I thought I had seen similar relations in other entities of that
type, but after rechecking the
JacquesLeRoux commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095516741
Ha, I think I know why now, because of
```
```
Right?
--
This is an automated message from the Apache Git Service.
To respond to the
JacquesLeRoux commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095508641
Hi @stschikin,
Why did you remove?
```
```
I see no pb with that.
--
This is an automated message from the Apache Git
stschikin commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095332774
Hi @JacquesLeRoux
thanks for your advice. I have edited the original post as requested.
--
This is an automated message from the Apache Git Service.
To respond to the
JacquesLeRoux commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2093093862
Hi @stschikin ,
Please provide a description following our description template. 2 reasons
here:
1. What's the problem or rather her reason of improvement
2.
sonarcloud[bot] commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2092728221
## [