Re: [Openvpn-devel] [PATCH] Silence warning about format string in check_ca_required

2021-06-08 Thread Selva Nair
Hi On Tue, Jun 8, 2021 at 3:44 PM Arne Schwabe wrote: > clang does not like if the format argument of printf like function > is not a string literal: > > warning: format string is not a string literal (potentially insecure) > > Use "%s" as string literal to silence the warning. > Format string

Re: [Openvpn-devel] [PATCH] Silence warning about format string in check_ca_required

2021-06-08 Thread Antonio Quartulli
Hi, On 08/06/2021 21:43, Arne Schwabe wrote: > clang does not like if the format argument of printf like function > is not a string literal: > > warning: format string is not a string literal (potentially insecure) > > Use "%s" as string literal to silence the warning. > > Signed-off-by: Arne

[Openvpn-devel] [PATCH] Silence warning about format string in check_ca_required

2021-06-08 Thread Arne Schwabe
clang does not like if the format argument of printf like function is not a string literal: warning: format string is not a string literal (potentially insecure) Use "%s" as string literal to silence the warning. Signed-off-by: Arne Schwabe --- src/openvpn/options.c | 2 +- 1 file changed, 1

Re: [Openvpn-devel] UNSUBSCRIBE

2021-06-08 Thread Antonio Quartulli
Please follow this URL to unsubscribe: https://lists.sourceforge.net/lists/listinfo/openvpn-devel Regards, On 08/06/2021 18:08, John Aron wrote: >   > > > > ___ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net >

[Openvpn-devel] UNSUBSCRIBE

2021-06-08 Thread John Aron
___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Implement Windows CA template match for Crypto-API selector

2021-06-08 Thread Selva Nair
Hi, Oh, it seems I replied to the stale thread (version 1). As Gert mentioned, please include a version tag and use --in-reply-to to keep it threaded in the next iteration. Some additional comments below. On Fri, Jun 4, 2021 at 10:41 AM Heiko Wundram wrote: > > The certificate selection

Re: [Openvpn-devel] [PATCH] Implement Windows CA template match for Crypto-API selector

2021-06-08 Thread Selva Nair
Hi, > > > > +static const CRYPT_OID_INFO * > > > +find_oid(DWORD keytype, const void *key, DWORD groupid, bool > > > +fallback) { > > > +const CRYPT_OID_INFO *info = NULL; > > > + > > > +/* force resolve from local as first step */ > > > +if (groupid != CRYPT_HASH_ALG_OID_GROUP_ID &&

[Openvpn-devel] [PATCH] Add github actions

2021-06-08 Thread Arne Schwabe
dummy0 gives strange errors on the Ubuntu 16 runner on github actions because dummy already exist, so use a more unique ovpn-dummy0 name instead. Github actions are a good alternative to travis-ci, which futrure is questionable at the moment without payment. The github actions also allows

[Openvpn-devel] [PATCH applied] Re: duplicate function declaration.

2021-06-08 Thread Gert Doering
Acked-by: Gert Doering Thanks. Seems someone from the core team really loves this function! Your patch has been applied to the master branch. For the next patch, please take care of a few things - do the git commit with "-s", to get the "signed-off-by:" line - your git setup is missing a