Re: [PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-09 Thread via GitHub
dongjoon-hyun commented on PR #46475: URL: https://github.com/apache/spark/pull/46475#issuecomment-2103351952 Here is a follow-up. - https://github.com/apache/spark/pull/46514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-09 Thread via GitHub
dongjoon-hyun commented on PR #46475: URL: https://github.com/apache/spark/pull/46475#issuecomment-2103336865 It seems that there are four failures at Java 17 at least. - https://github.com/apache/spark/runs/24788991819 -- This is an automated message from the Apache Git Service. To

Re: [PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-08 Thread via GitHub
cloud-fan closed pull request #46475: [SPARK-48197][SQL] Avoid assert error for invalid lambda function URL: https://github.com/apache/spark/pull/46475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-08 Thread via GitHub
cloud-fan commented on PR #46475: URL: https://github.com/apache/spark/pull/46475#issuecomment-2101842034 thanks for review, merging to master/3.5! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-08 Thread via GitHub
cloud-fan commented on code in PR #46475: URL: https://github.com/apache/spark/pull/46475#discussion_r1594905571 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -955,7 +955,14 @@ object FunctionRegistry { since:

Re: [PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-08 Thread via GitHub
allisonwang-db commented on code in PR #46475: URL: https://github.com/apache/spark/pull/46475#discussion_r1594717536 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -955,7 +955,14 @@ object FunctionRegistry { since:

Re: [PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-08 Thread via GitHub
dongjoon-hyun commented on PR #46475: URL: https://github.com/apache/spark/pull/46475#issuecomment-2100882656 Is the UT failure relevant, @cloud-fan ? ``` [info] *** 1 TEST FAILED *** [error] Failed: Total 10583, Failed 1, Errors 0, Passed 10582, Ignored 29 [error] Failed tests:

[PR] [SPARK-48197][SQL] Avoid assert error for invalid lambda function [spark]

2024-05-08 Thread via GitHub
cloud-fan opened a new pull request, #46475: URL: https://github.com/apache/spark/pull/46475 ### What changes were proposed in this pull request? `ExpressionBuilder` asserts all its input expressions to be resolved during lookup, which is not true as the analyzer rule