[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix hiding of thumbnails in reading list detail view.

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405841 )

Change subject: Fix hiding of thumbnails in reading list detail view.
......................................................................

Fix hiding of thumbnails in reading list detail view.

Bug: T185541
Change-Id: Iae51d68e1e158789c600f00a499753ac4d258278
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
M app/src/main/res/layout/item_reading_list.xml
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/41/405841/1

diff --git 
a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java 
b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
index acdf7c7..e8daed8 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.java
@@ -52,6 +52,7 @@
     @BindView(R.id.item_description) TextView descriptionView;
     @BindView(R.id.item_overflow_menu)View overflowButton;
 
+    @BindView(R.id.item_thumbnails_container) View thumbnailsContainer;
     @BindView(R.id.item_image_container) View imageContainer;
     @BindView(R.id.default_list_empty_image) ImageView defaultListEmptyView;
     @BindViews({R.id.item_image_1, R.id.item_image_2, R.id.item_image_3, 
R.id.item_image_4}) List<SimpleDraweeView> imageViews;
@@ -94,7 +95,7 @@
         statisticalDescriptionView.setText(text);
 
         updateDetails();
-        if (imageContainer.getVisibility() == VISIBLE) {
+        if (thumbnailsContainer.getVisibility() == VISIBLE) {
             updateThumbnails();
         }
     }
@@ -108,7 +109,7 @@
     }
 
     public void setThumbnailVisible(boolean visible) {
-        imageContainer.setVisibility(visible ? VISIBLE : GONE);
+        thumbnailsContainer.setVisibility(visible ? VISIBLE : GONE);
     }
 
     public void setShowDescriptionEmptyHint(boolean show) {
diff --git a/app/src/main/res/layout/item_reading_list.xml 
b/app/src/main/res/layout/item_reading_list.xml
index 84da7bd..aa62c42 100644
--- a/app/src/main/res/layout/item_reading_list.xml
+++ b/app/src/main/res/layout/item_reading_list.xml
@@ -16,6 +16,7 @@
         android:layout_margin="16dp">
 
         <FrameLayout
+            android:id="@+id/item_thumbnails_container"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content">
 

-- 
To view, visit https://gerrit.wikimedia.org/r/405841
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae51d68e1e158789c600f00a499753ac4d258278
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits