Phantom42 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406044 )
Change subject: Add PHP_CodeSniffer for codestyle checks ...................................................................... Add PHP_CodeSniffer for codestyle checks All failing rules are excluded now, but will be reenabled in next patches. Bug: T185492 Change-Id: Ib985f56931f4694d82a3ec7e0dc82e8c3d153748 --- A .phpcs.xml M composer.json 2 files changed, 126 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLexicalData refs/changes/44/406044/1 diff --git a/.phpcs.xml b/.phpcs.xml new file mode 100644 index 0000000..e54d791 --- /dev/null +++ b/.phpcs.xml @@ -0,0 +1,123 @@ +<?xml version="1.0"?> +<ruleset> + <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> + <exclude name="Generic.Arrays.DisallowLongArraySyntax.Found" /> + <exclude name="Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed" /> + <exclude name="Generic.CodeAnalysis.UnconditionalIfStatement.Found" /> + <exclude name="Generic.ControlStructures.InlineControlStructure.NotAllowed" /> + <exclude name="Generic.Files.LineLength.TooLong" /> + <exclude name="Generic.Files.OneObjectStructurePerFile.MultipleFound" /> + <exclude name="Generic.Formatting.DisallowMultipleStatements.SameLine" /> + <exclude name="Generic.Formatting.MultipleStatementAlignment.IncorrectWarning" /> + <exclude name="Generic.Formatting.NoSpaceAfterCast.SpaceFound" /> + <exclude name="Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma" /> + <exclude name="Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma" /> + <exclude name="Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine" /> + <exclude name="Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace" /> + <exclude name="Generic.Functions.OpeningFunctionBraceKernighanRitchie.SpaceBeforeBrace" /> + <exclude name="Generic.NamingConventions.ConstructorName.OldStyle" /> + <exclude name="Generic.NamingConventions.UpperCaseConstantName.ConstantNotUpperCase" /> + <exclude name="Generic.PHP.ForbiddenFunctions.FoundWithAlternative" /> + <exclude name="Generic.PHP.LowerCaseConstant.Found" /> + <exclude name="Generic.PHP.LowerCaseKeyword.Found" /> + <exclude name="Generic.PHP.NoSilencedErrors.Discouraged" /> + <exclude name="Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed" /> + <exclude name="Internal.Exception" /> + <exclude name="MediaWiki.Commenting.FunctionComment.CloseTagOwnLine" /> + <exclude name="MediaWiki.Commenting.FunctionComment.DuplicateReturn" /> + <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" /> + <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" /> + <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment" /> + <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamName" /> + <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" /> + <exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" /> + <exclude name="MediaWiki.Commenting.FunctionComment.NotPunctuationReturn" /> + <exclude name="MediaWiki.Commenting.FunctionComment.NotShortBoolReturn" /> + <exclude name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SpacingAfter" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SpacingDocStar" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SpacingDocStarSingleLine" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SpacingDocTag" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SpacingSingleLineCloseTag" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SyntaxAlignedDocClose" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SyntaxAlignedDocStar" /> + <exclude name="MediaWiki.Commenting.FunctionComment.SyntaxCloseTag" /> + <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" /> + <exclude name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures" /> + <exclude name="MediaWiki.ControlStructures.IfElseStructure.SpaceAfterElse" /> + <exclude name="MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse" /> + <exclude name="MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords" /> + <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" /> + <exclude name="MediaWiki.Files.ClassMatchesFilename.WrongCase" /> + <exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" /> + <exclude name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix" /> + <exclude name="MediaWiki.NamingConventions.ValidGlobalName.wgPrefix" /> + <exclude name="MediaWiki.Usage.DbrQueryUsage.DbrQueryFound" /> + <exclude name="MediaWiki.Usage.DirUsage.FunctionFound" /> + <exclude name="MediaWiki.Usage.ForbiddenFunctions.extract" /> + <exclude name="MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals" /> + <exclude name="MediaWiki.VariableAnalysis.ForbiddenGlobalVariables.ForbiddenGlobal$wgTitle" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$myWordnikAPIKey" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$params" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$relationsObjectAttributesEditor" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wdCurrentContext" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wdTermDBDataSet" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgDBprefix" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgDBtype" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgDefaultClassMids" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgOut" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgRequest" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgScript" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgScriptPath" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgUser" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgWikidataDataSet" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgWldDMValueObjectAttributesEditors" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgWldOptionValueObjectAttributesEditors" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgWldOwScriptPath" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgWldTextValueObjectAttributesEditors" /> + <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables.UnusedGlobal$wgWldTranslatedTextValueObjectAttributesEditors" /> + <exclude name="MediaWiki.WhiteSpace.DisallowEmptyLineFunctions.NoEmptyLine" /> + <exclude name="MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines" /> + <exclude name="MediaWiki.WhiteSpace.OpeningKeywordParenthesis.WrongWhitespaceBeforeParenthesis" /> + <exclude name="MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect" /> + <exclude name="MediaWiki.WhiteSpace.SpaceBeforeControlStructureBrace.BraceOnNewLine" /> + <exclude name="MediaWiki.WhiteSpace.SpaceBeforeControlStructureBrace.EmptyLines" /> + <exclude name="MediaWiki.WhiteSpace.SpaceBeforeControlStructureBrace.SpaceBeforeControl" /> + <exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" /> + <exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment" /> + <exclude name="MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis" /> + <exclude name="MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis" /> + <exclude name="MediaWiki.WhiteSpace.SpaceyParenthesis.SpaceBeforeOpeningParenthesis" /> + <exclude name="MediaWiki.WhiteSpace.SpaceyParenthesis.UnnecessarySpaceBetweenParentheses" /> + <exclude name="PSR2.Classes.PropertyDeclaration.ScopeMissing" /> + <exclude name="PSR2.Classes.PropertyDeclaration.Underscore" /> + <exclude name="PSR2.Classes.PropertyDeclaration.VarUsed" /> + <exclude name="PSR2.Files.EndFileNewline.NoneFound" /> + <exclude name="PSR2.Files.EndFileNewline.TooMany" /> + <exclude name="PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose" /> + <exclude name="PSR2.Methods.MethodDeclaration.AbstractAfterVisibility" /> + <exclude name="PSR2.Methods.MethodDeclaration.Underscore" /> + <exclude name="Squiz.Classes.SelfMemberReference.NotUsed" /> + <exclude name="Squiz.Classes.SelfMemberReference.SpaceAfter" /> + <exclude name="Squiz.Classes.SelfMemberReference.SpaceBefore" /> + <exclude name="Squiz.Classes.ValidClassName.NotCamelCaps" /> + <exclude name="Squiz.Operators.ValidLogicalOperators.NotAllowed" /> + <exclude name="Squiz.Scope.MemberVarScope.Missing" /> + <exclude name="Squiz.Scope.MethodScope.Missing" /> + <exclude name="Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect" /> + <exclude name="Squiz.WhiteSpace.LanguageConstructSpacing.IncorrectSingle" /> + <exclude name="Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfter" /> + <exclude name="Squiz.WhiteSpace.OperatorSpacing.NoSpaceBefore" /> + <exclude name="Squiz.WhiteSpace.OperatorSpacing.SpacingAfter" /> + <exclude name="Squiz.WhiteSpace.OperatorSpacing.SpacingBefore" /> + <exclude name="Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore" /> + <exclude name="Squiz.WhiteSpace.ScopeClosingBrace.Indent" /> + <exclude name="Squiz.WhiteSpace.ScopeKeywordSpacing.Incorrect" /> + <exclude name="Squiz.WhiteSpace.SemicolonSpacing.Incorrect" /> + <exclude name="Squiz.WhiteSpace.SuperfluousWhitespace.EndLine" /> + <exclude name="Zend.Files.ClosingTag.NotAllowed" /> + </rule> + <file>.</file> + <arg name="extensions" value="php,php5,inc" /> + <arg name="encoding" value="UTF-8" /> +</ruleset> diff --git a/composer.json b/composer.json index 7d306d5..7f42a6e 100644 --- a/composer.json +++ b/composer.json @@ -2,14 +2,17 @@ "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", "jakub-onderka/php-console-highlighter": "0.3.2", + "mediawiki/mediawiki-codesniffer": "15.0.0", "mediawiki/minus-x": "0.2.1" }, "scripts": { "test": [ "parallel-lint . --exclude vendor --exclude node_modules", + "phpcs -p -s", "minus-x check ." ], "fix": [ + "phpcbf", "minus-x fix ." ] } -- To view, visit https://gerrit.wikimedia.org/r/406044 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib985f56931f4694d82a3ec7e0dc82e8c3d153748 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiLexicalData Gerrit-Branch: master Gerrit-Owner: Phantom42 <nikita...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits