jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405995 )
Change subject: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs ...................................................................... cover: Convert coverage sub-nav from breadcrumbs to nav-tabs Breadcrumbs are mainly intended as a way to go from a subpage back to an ancestor. Not as a way of going to a subpage. Given the similarity, it looks somewhat confusing to see the breadcrumbs visually end with 'MediaWiki extensions' when the user isn't actually on that page. Nav-tabs seems like a more appropiate fit within the building blocks that Bootstrap provides. Change-Id: Ic7b0cf9d76ed79f12074adf07d054e1fd2456746 --- M shared/CoveragePage.php 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Krinkle: Looks good to me, approved Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/shared/CoveragePage.php b/shared/CoveragePage.php index 5314f43..81583ec 100644 --- a/shared/CoveragePage.php +++ b/shared/CoveragePage.php @@ -52,18 +52,18 @@ if ( $this->pageName === 'Test coverage' ) { $href = $this->fixNavUrl( '/cover-extensions/' ); $breadcrumbs = <<<HTML -<ol class="breadcrumb"> - <li class="active">Coverage home</li> +<ul class="nav nav-tabs"> + <li class="active"><a href="#">Coverage home</a></li> <li><a href="$href">MediaWiki extensions</a></li> -</ol> +</ul> HTML; } else { $href = $this->fixNavUrl( '/cover/' ); $breadcrumbs = <<<HTML -<ol class="breadcrumb"> +<ul class="nav nav-tabs"> <li><a href="$href">Coverage home</a></li> - <li class="active">MediaWiki extensions</li> -</ol> + <li class="active"><a href="#">MediaWiki extensions</a></li> +</ul> HTML; } $this->addHtmlContent( $breadcrumbs ); -- To view, visit https://gerrit.wikimedia.org/r/405995 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7b0cf9d76ed79f12074adf07d054e1fd2456746 Gerrit-PatchSet: 3 Gerrit-Project: integration/docroot Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits