jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406031 )
Change subject: Fix PHPDocs of GadgetDefinitionContent::getDeletionUpdates ...................................................................... Fix PHPDocs of GadgetDefinitionContent::getDeletionUpdates DataUpdate is a specific implementation (currently the only one), while DeferrableUpdate is the interface. Binding against the interface is enough, and what the base classes already do. I'm also removing a line of meaningless documentation. "Creates an instance of this class" is a general description that is true for all constructors. Change-Id: Ia6dc86b078628db5e0ab68ef46bf0396567b767c --- M includes/GadgetResourceLoaderModule.php M includes/content/GadgetDefinitionContent.php 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: MaxSem: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/GadgetResourceLoaderModule.php b/includes/GadgetResourceLoaderModule.php index e1b2602..13d16cd 100644 --- a/includes/GadgetResourceLoaderModule.php +++ b/includes/GadgetResourceLoaderModule.php @@ -16,8 +16,6 @@ private $gadget; /** - * Creates an instance of this class - * * @param array $options */ public function __construct( array $options ) { diff --git a/includes/content/GadgetDefinitionContent.php b/includes/content/GadgetDefinitionContent.php index b5aa7cf..cede38d 100644 --- a/includes/content/GadgetDefinitionContent.php +++ b/includes/content/GadgetDefinitionContent.php @@ -97,7 +97,7 @@ /** * @param WikiPage $page * @param ParserOutput $parserOutput - * @return DataUpdate[] + * @return DeferrableUpdate[] */ public function getDeletionUpdates( WikiPage $page, ParserOutput $parserOutput = null ) { return array_merge( -- To view, visit https://gerrit.wikimedia.org/r/406031 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6dc86b078628db5e0ab68ef46bf0396567b767c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Gadgets Gerrit-Branch: master Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits