PierreSmits commented on code in PR #790:
URL: https://github.com/apache/ofbiz-framework/pull/790#discussion_r1589130204
##########
applications/accounting/ofbiz-component.xml:
##########
@@ -31,6 +31,8 @@ under the License.
<entity-resource type="data" reader-name="seed" loader="main"
location="data/AccountingPortletData.xml"/>
<entity-resource type="data" reader-name="seed-initial" loader="main"
location="data/AccountingScheduledServiceData.xml"/>
+ <service-resource type="model" loader="main"
location="servicedef/services.xml"/>
Review Comment:
Thanks Nicolas, for the suggestion.
However, there are more of those arithmetic functions to get such setting
used in various xml, groovy and java files. I prefer to have those in a single
services.xml file, instead having those spread across many files.
Plus, having a generic 'services.xml' in the accounting component brings the
component more in line with others (and the templates for creating a new
plugin). Such would enhance the developer (and thus the contributor)
experience.
I trust you find my solution acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
