dongjoon-hyun commented on code in PR #46373: URL: https://github.com/apache/spark/pull/46373#discussion_r1589790522
########## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala: ########## @@ -78,7 +79,16 @@ private[spark] abstract class KubernetesConf(val sparkConf: SparkConf) { def getOption(key: String): Option[String] = sparkConf.getOption(key) } -private[spark] class KubernetesDriverConf( + Review Comment: Please remove this redundant empty line addition. ########## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala: ########## @@ -78,7 +79,16 @@ private[spark] abstract class KubernetesConf(val sparkConf: SparkConf) { def getOption(key: String): Option[String] = sparkConf.getOption(key) } -private[spark] class KubernetesDriverConf( + +/** + * :: DeveloperApi :: + * + * Used for K8s operations internally and Spark K8s operator. + */ +@Unstable +@DeveloperApi +@Since("4.0.0") Review Comment: Is this correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org