panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1590748268
##########
common/utils/src/main/java/org/apache/spark/internal/Logger.java:
##########
@@ -34,10 +34,26 @@ public class Logger {
this.slf4jLogger = slf4jLogger;
}
+ public boolean isErrorEnabled() {
+ return slf4jLogger.isErrorEnabled();
+ }
+
public void error(String msg) {
slf4jLogger.error(msg);
}
+ public void error(String msg, String arg) {
+ slf4jLogger.error(msg, arg);
+ }
+
+ public void error(String msg, String arg1, String arg2) {
+ slf4jLogger.error(msg, arg1, arg2);
+ }
+
+ public void error(String msg, String... args) {
Review Comment:
Why is the method signature not `public void error(String msg, Object...
args)`
Because it conflicts with `public void error(String msg, MDC... mdcs)`
When we want to use `error(String msg, MDC... mdcs)`, it will enter
`error(String msg, Object... args)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
