GideonPotok commented on PR #46404: URL: https://github.com/apache/spark/pull/46404#issuecomment-2096348487
@uros-db This is ready for the initial round of review. Let me know what you think! I left two todos, that I will add to this branch in the next day or two. They are: 1. finish the function to benchmark performance impact 2. since null is not a valid key for tree map, I have to add support for mode to be null, even when mode is on a string column, in which case the hash map gets copied over to treetop). I will then modify the test for this, accordingly. This feature has been very interesting. Thanks for letting me claim it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
