gengliangwang commented on code in PR #46390: URL: https://github.com/apache/spark/pull/46390#discussion_r1591854610
########## core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java: ########## @@ -476,8 +479,9 @@ public void insertRecord( assert(inMemSorter != null); if (inMemSorter.numRecords() >= numElementsForSpillThreshold) { - logger.info("Spilling data because number of spilledRecords crossed the threshold " + - numElementsForSpillThreshold); + logger.info("Spilling data because number of spilledRecords crossed the threshold {}", + MDC.of(LogKeys.SHUFFLE_SPILL_NUM_ELEMENTS_FORCE_SPILL_THRESHOLD$.MODULE$, Review Comment: this key is sort of long. How about `NUM_ELEMENTS_SPILL_THRESHOLD`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org