Bug#1065725: adns: FTBFS on arm{el,hf}: FAILED ./case-1stservbroken - WRONG OUTPUT - lines of syscall remaining 0
Dan Bungert writes ("Bug#1065725: adns: FTBFS on arm{el,hf}: FAILED
./case-1stservbroken - WRONG OUTPUT - lines of syscall remaining 0"):
> I took a look at this bug today.
> I found that the regress testsuite make use of some negative offsets, which
> seem to perplex the reader on 32 bit systems.
>
> Please see the attached patch, which has allowed this to build for Ubuntu.
Thanks. I fixed the problem a little differently, in an upstream
release. (Your patch didn't work for me.)
I have just uploaded to Debian too. You may wish to pick up upstream
1.6.1 via Debian's 1.6.1-1 (or wait for it to build and migrate, maybe).
Ian.
--
Ian JacksonThese opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
Bug#1065725: adns: FTBFS on arm{el,hf}: FAILED ./case-1stservbroken - WRONG OUTPUT - lines of syscall remaining 0
Greetings!
I took a look at this bug today.
I found that the regress testsuite make use of some negative offsets, which
seem to perplex the reader on 32 bit systems.
Please see the attached patch, which has allowed this to build for Ubuntu.
-Dan
Author: Dan Bungert
Description: Fix reads of signed values into unsigned variables
Bug-Ubuntu: https://bugs.launchpad.net/bugs/2057735
Bug-Debian: https://bugs.debian.org/1065725
Forwarded: yes
Last-Update: 2024-03-14
The regress testsuite makes use of time offsets to mock the passage of time,
and some of the usec values are expressed as negative numbers. Update the
reader to be able to handle that.
--- a/regress/hplayback.c.m4
+++ b/regress/hplayback.c.m4
@@ -108,7 +108,8 @@
void Tensuresetup(void) {
int fd;
int chars;
- unsigned long sec, usec;
+ time_t sec;
+ suseconds_t usec;
Tensure_reportfile();
Tensure_fuzzrawfile();
@@ -124,7 +125,7 @@
if (!adns__vbuf_ensure(,1000)) Tnomem();
fgets(vb2.buf,vb2.avail,Tinputfile); Pcheckinput();
chars= -1;
- sscanf(vb2.buf," start %lu.%lu%n",,,);
+ sscanf(vb2.buf," start %lld.%ld%n",,,);
if (chars==-1) Psyntax("start time invalid");
currenttime.tv_sec= sec;
currenttime.tv_usec= usec;
@@ -170,12 +171,13 @@
static void P_updatetime(void) {
int chars;
- unsigned long sec, usec;
+ time_t sec;
+ suseconds_t usec;
if (!adns__vbuf_ensure(,1000)) Tnomem();
fgets(vb2.buf,vb2.avail,Tinputfile); Pcheckinput();
chars= -1;
- sscanf(vb2.buf," +%lu.%lu%n",,,);
+ sscanf(vb2.buf," +%lld.%ld%n",,,);
if (chars==-1) Psyntax("update time invalid");
currenttime.tv_sec+= sec;
currenttime.tv_usec+= usec;
Bug#1065725: adns: FTBFS on arm{el,hf}: FAILED ./case-1stservbroken - WRONG OUTPUT - lines of syscall remaining 0
Source: adns Version: 1.6.0-2.1 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) X-Debbugs-Cc: sramac...@debian.org https://buildd.debian.org/status/fetch.php?pkg=adns=armhf=1.6.0-2.1=1709082246=0 make[2]: Entering directory '/<>/regress' --- ./case-1stservbroken.out2020-06-11 15:01:23.0 + +++ output-1stservbroken.out2024-02-28 01:04:01.650317863 + @@ -5,7 +5,7 @@ adns debug: TCP connected (NS=172.18.45.2) adns warning: TCP connection failed: read: Broken pipe (NS=172.18.45.2) adns debug: TCP connected (NS=172.18.45.6) -trunc.test.iwj.relativity.greenend.org.uk flags 0 type PTR(raw): OK; nrrs=30; cname=$; owner=$; ttl=60 +trunc.test.iwj.relativity.greenend.org.uk flags 0 type PTR(raw): OK; nrrs=30; cname=$; owner=$; ttl=57 long.domain.to.force.truncation.0.test.iwj.relativity.greenend.org.uk long.domain.to.force.truncation.1.test.iwj.relativity.greenend.org.uk long.domain.to.force.truncation.2.test.iwj.relativity.greenend.org.uk FAILED ./case-1stservbroken - WRONG OUTPUT - lines of syscall remaining 0 make[2]: *** [Makefile:78: check-1stservbroken] Error 1 Cheers -- Sebastian Ramacher
