Bug#1066662: hping3: FTBFS: script.c:1351:29: error: implicit declaration of function ‘asprintf’; did you mean ‘vsprintf’? [-Werror=implicit-function-declaration]

2024-05-06 Thread Michael Prokop
* Lucas Nussbaum [Wed Mar 13, 2024 at 12:51:29PM +0100]:

[...]
> This is most likely caused by a change in dpkg 1.22.6, that enabled
> -Werror=implicit-function-declaration. For more information, see
> https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
> 
> Relevant part (hopefully):
> > gcc -c -g -O2 -Werror=implicit-function-declaration 
> > -ffile-prefix-map=/<>=. -fstack-protector-strong 
> > -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> > -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -Wall -I/usr/include/pcap 
> > -I/usr/include/tcl8.6 -DUSE_TCL -g  ars.c
> > script.c: In function ‘HpingTcl_AppInit’:
> > script.c:1351:29: error: implicit declaration of function ‘asprintf’; did 
> > you mean ‘vsprintf’? [-Werror=implicit-function-declaration]
> >  1351 | if (asprintf(, "%s/.hpingrc", home) 
> > < 0)
> >   | ^~~~
> >   | vsprintf
[...]

Pending patch / MR available at
https://salsa.debian.org/debian/hping3/-/merge_requests/4

regards
-mika-


signature.asc
Description: PGP signature


Bug#1066662: hping3: FTBFS: script.c:1351:29: error: implicit declaration of function ‘asprintf’; did you mean ‘vsprintf’? [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: hping3
Version: 3.a2.ds2-10
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -Wall -I/usr/include/pcap 
> -I/usr/include/tcl8.6 -DUSE_TCL -g  ars.c
> script.c: In function ‘HpingTcl_AppInit’:
> script.c:1351:29: error: implicit declaration of function ‘asprintf’; did you 
> mean ‘vsprintf’? [-Werror=implicit-function-declaration]
>  1351 | if (asprintf(, "%s/.hpingrc", home) < 
> 0)
>   | ^~~~
>   | vsprintf
> gcc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -Wall -I/usr/include/pcap 
> -I/usr/include/tcl8.6 -DUSE_TCL -g  apd.c
> gcc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -Wall -I/usr/include/pcap 
> -I/usr/include/tcl8.6 -DUSE_TCL -g  split.c
> In file included from ars.c:15:
> ars.c: In function ‘ars_multi_cksum’:
> ars.c:485:60: warning: comparison with string literal results in unspecified 
> behavior [-Waddress]
>   485 | assert("else reached in ars_multi_cksum()" == "");
>   |^~
> ars.c:485:60: warning: comparison with string literal results in unspecified 
> behavior [-Waddress]
>   485 | assert("else reached in ars_multi_cksum()" == "");
>   |^~
> ars.c: In function ‘ars_bsd_fix’:
> ars.c:909:27: warning: variable ‘ip’ set but not used 
> [-Wunused-but-set-variable]
>   909 | struct ars_iphdr *ip;
>   |   ^~
> In file included from /usr/include/string.h:535,
>  from scan.c:17:
> In function ‘memcpy’,
> inlined from ‘receiver’ at scan.c:459:4,
> inlined from ‘scanmain’ at scan.c:545:3:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: warning: 
> ‘__builtin___memcpy_chk’ forming offset [8, 19] is out of the bounds [0, 8] 
> of object ‘icmp’ with type ‘struct myicmphdr’ [-Warray-bounds=]
>29 |   return __builtin___memcpy_chk (__dest, __src, __len,
>   |  ^
>30 |  __glibc_objsize0 (__dest));
>   |  ~~
> scan.c: In function ‘scanmain’:
> scan.c:445:42: note: ‘icmp’ declared here
>   445 | struct myicmphdr icmp;
>   |  ^~~~
> gcc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O2 -Wall -I/usr/include/pcap 
> -I/usr/include/tcl8.6 -DUSE_TCL -g  rapd.c
> apd.c: In function ‘ars_decode_hex’:
> apd.c:823:16: warning: pointer targets in returning ‘unsigned char *’ from a 
> function with return type ‘char *’ differ in signedness [-Wpointer-sign]
>   823 | return saved;
>   |^
> apd.c: In function ‘ars_decode_string’:
> apd.c:852:16: warning: pointer targets in returning ‘unsigned char *’ from a 
> function with return type ‘char *’ differ in signedness [-Wpointer-sign]
>   852 | return saved;
>   |^
> apd.c: In function ‘ars_d_set_data’:
> apd.c:889:21: warning: variable ‘err’ set but not used 
> [-Wunused-but-set-variable]
>   889 | int err, blen;
>   | ^~~
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:66: script.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/hping3_3.a2.ds2-10_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at