Re: [PR] [SPARK-45220][FOLLOWUP][DOCS][TESTS] Make a `dataframe.join` doctest deterministic [spark]
dongjoon-hyun commented on PR #46398: URL: https://github.com/apache/spark/pull/46398#issuecomment-2096536726 cc @allisonwang-db , too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45220][FOLLOWUP][DOCS][TESTS] Make a `dataframe.join` doctest deterministic [spark]
dongjoon-hyun closed pull request #46398: [SPARK-45220][FOLLOWUP][DOCS][TESTS] Make a `dataframe.join` doctest deterministic URL: https://github.com/apache/spark/pull/46398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-45220][FOLLOWUP][DOCS][TESTS] Make a `dataframe.join` doctest deterministic [spark]
dongjoon-hyun commented on code in PR #46398:
URL: https://github.com/apache/spark/pull/46398#discussion_r1591323888
##
python/pyspark/sql/dataframe.py:
##
@@ -2524,7 +2524,7 @@ def join(
Outer join on multiple columns
->>> df.join(df3, ["name", "age"], "outer").show()
+>>> df.join(df3, ["name", "age"], "outer").sort("name", "age").show()
Review Comment:
This is a follow-up of
- https://github.com/apache/spark/pull/43039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
