Re: [PR] [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs [spark]
dongjoon-hyun commented on code in PR #46395:
URL: https://github.com/apache/spark/pull/46395#discussion_r1591209235
##
.github/workflows/build_and_test.yml:
##
@@ -80,12 +80,14 @@ jobs:
pyspark=`./dev/is-changed.py -m $pyspark_modules`
if [[ "${{ github.repository }}" != 'apache/spark' ]]; then
pandas=$pyspark
+yarn=`./dev/is-changed.py -m yarn`
Review Comment:
Yes, `source_file_regexes` has `common/network-yarn` and I believe it makes
sense.
https://github.com/apache/spark/blob/7c728b2c2d6cbe2b8310cd8cf8aa4c2528b489c8/dev/sparktestsupport/modules.py#L1447-L1460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs [spark]
LuciferYang commented on code in PR #46395:
URL: https://github.com/apache/spark/pull/46395#discussion_r1590572555
##
.github/workflows/build_and_test.yml:
##
@@ -80,12 +80,14 @@ jobs:
pyspark=`./dev/is-changed.py -m $pyspark_modules`
if [[ "${{ github.repository }}" != 'apache/spark' ]]; then
pandas=$pyspark
+yarn=`./dev/is-changed.py -m yarn`
Review Comment:
Sorry, I just reviewed `modules.py` and have a small question: if the
`common/network-yarn` module has changed, should `yarn` also be set to true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs [spark]
dongjoon-hyun closed pull request #46395: [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs URL: https://github.com/apache/spark/pull/46395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs [spark]
dongjoon-hyun commented on PR #46395: URL: https://github.com/apache/spark/pull/46395#issuecomment-2095248825 Thank you so much! Merged to master~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs [spark]
dongjoon-hyun commented on PR #46395: URL: https://github.com/apache/spark/pull/46395#issuecomment-2095237705 Could you review this PR too, @LuciferYang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs [spark]
dongjoon-hyun commented on PR #46395: URL: https://github.com/apache/spark/pull/46395#issuecomment-2095122806 Alternatively, we can ignore `YarnClusterSuite` completely. However, I'm not sure who is going to take on that JIRA issue in the future. So, I choose this path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48137][INFRA] Run `yarn` test only in PR builders and Daily CIs [spark]
dongjoon-hyun commented on PR #46395: URL: https://github.com/apache/spark/pull/46395#issuecomment-2095112747 WDYT, @HyukjinKwon ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
