Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
LucaCanali commented on PR #46399: URL: https://github.com/apache/spark/pull/46399#issuecomment-2097576342 Thank you @dongjoon-hyun and @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
dongjoon-hyun closed pull request #46399: [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free URL: https://github.com/apache/spark/pull/46399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
yaooqinn commented on code in PR #46399:
URL: https://github.com/apache/spark/pull/46399#discussion_r1591728412
##
.github/workflows/build_and_test.yml:
##
@@ -929,7 +929,7 @@ jobs:
HIVE_PROFILE: hive2.3
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
- ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3
+ ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4
Review Comment:
+1 for removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
dongjoon-hyun commented on code in PR #46399:
URL: https://github.com/apache/spark/pull/46399#discussion_r1591333213
##
.github/workflows/build_and_test.yml:
##
@@ -929,7 +929,7 @@ jobs:
HIVE_PROFILE: hive2.3
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
- ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3
+ ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4
Review Comment:
BTW, if this PR affects old release branch's test coverage due to
`.github/workflows/build_and_test.yml` change, it would be very weird. What
fixed versions should we use for SPARK-48141?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
dongjoon-hyun commented on code in PR #46399:
URL: https://github.com/apache/spark/pull/46399#discussion_r1591318876
##
.github/workflows/build_and_test.yml:
##
@@ -929,7 +929,7 @@ jobs:
HIVE_PROFILE: hive2.3
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
- ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3
+ ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4
Review Comment:
`sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME",
"gvenzl/oracle-free:23.4-slim")` is enough, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
dongjoon-hyun commented on code in PR #46399:
URL: https://github.com/apache/spark/pull/46399#discussion_r1591318876
##
.github/workflows/build_and_test.yml:
##
@@ -929,7 +929,7 @@ jobs:
HIVE_PROFILE: hive2.3
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
- ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3
+ ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4
Review Comment:
`sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME",
"gvenzl/oracle-free:23.4-slim")` is enough, isn't it? Or, is this required for
old release branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
dongjoon-hyun commented on code in PR #46399:
URL: https://github.com/apache/spark/pull/46399#discussion_r1591318876
##
.github/workflows/build_and_test.yml:
##
@@ -929,7 +929,7 @@ jobs:
HIVE_PROFILE: hive2.3
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
- ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3
+ ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4
Review Comment:
`sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME",
"gvenzl/oracle-free:23.4-slim")` is enough, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
dongjoon-hyun commented on code in PR #46399:
URL: https://github.com/apache/spark/pull/46399#discussion_r1591318515
##
.github/workflows/build_and_test.yml:
##
@@ -929,7 +929,7 @@ jobs:
HIVE_PROFILE: hive2.3
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
- ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3
+ ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4
Review Comment:
Shall we remove this because we don't need this env variable, @LucaCanali
and @yaooqinn ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free [spark]
yaooqinn commented on PR #46399: URL: https://github.com/apache/spark/pull/46399#issuecomment-2096061092 Also cc @gvenzl from https://github.com/gvenzl/oci-oracle-free/issues/35#issuecomment-2094893041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
