[Bug 1892456] Re: [MIR] malcontent
Override component to main malcontent 0.12.0-1 in oracular: universe/misc -> main Override [y|N]? y Override component to main gir1.2-malcontent-0 0.12.0-1 in oracular amd64: universe/introspection/optional/100% -> main gir1.2-malcontent-0 0.12.0-1 in oracular arm64: universe/introspection/optional/100% -> main gir1.2-malcontent-0 0.12.0-1 in oracular armhf: universe/introspection/optional/100% -> main gir1.2-malcontent-0 0.12.0-1 in oracular ppc64el: universe/introspection/optional/100% -> main gir1.2-malcontent-0 0.12.0-1 in oracular riscv64: universe/introspection/optional/100% -> main gir1.2-malcontent-0 0.12.0-1 in oracular s390x: universe/introspection/optional/100% -> main Override [y|N]? y 6 publications overridden. Override component to main libpam-malcontent 0.12.0-1 in oracular amd64: universe/admin/optional/100% -> main libpam-malcontent 0.12.0-1 in oracular arm64: universe/admin/optional/100% -> main libpam-malcontent 0.12.0-1 in oracular armhf: universe/admin/optional/100% -> main libpam-malcontent 0.12.0-1 in oracular ppc64el: universe/admin/optional/100% -> main libpam-malcontent 0.12.0-1 in oracular riscv64: universe/admin/optional/100% -> main libpam-malcontent 0.12.0-1 in oracular s390x: universe/admin/optional/100% -> main Override [y|N]? y 6 publications overridden. Override component to main libmalcontent-0-0 0.12.0-1 in oracular amd64: universe/libs/optional/100% -> main libmalcontent-0-0 0.12.0-1 in oracular arm64: universe/libs/optional/100% -> main libmalcontent-0-0 0.12.0-1 in oracular armhf: universe/libs/optional/100% -> main libmalcontent-0-0 0.12.0-1 in oracular ppc64el: universe/libs/optional/100% -> main libmalcontent-0-0 0.12.0-1 in oracular riscv64: universe/libs/optional/100% -> main libmalcontent-0-0 0.12.0-1 in oracular s390x: universe/libs/optional/100% -> main Override [y|N]? y 6 publications overridden. ** Changed in: malcontent (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
Extra-Exclude added in https://git.launchpad.net/~ubuntu-core- dev/ubuntu-seeds/+git/ubuntu/commit/?id=525d0a77 gnome-control-center upload enabling the corresponding option https://launchpad.net/ubuntu/+source/gnome-control-center/1:46.1-1ubuntu2 ** Changed in: malcontent (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
Hi, doing the re-review with the changed conditions. Indeed the former blocker can now be avoided. The packages you ask for only imply the following (which is fine): libmalcontent-0-0 Depends: libc6 (>= 2.4), libglib2.0-0t64 (>= 2.79.0) gir1.2-malcontent-0 Depends: gir1.2-gio-2.0, gir1.2-gobject-2.0, libmalcontent-0-0 (>= 0.10.0) libpam-malcontent Depends: libc6 (>= 2.4), libglib2.0-0t64 (>= 2.60), libmalcontent-0-0 (>= 0.6.0), libpam0g (>= 0.99.7.1) Therefore let me extend the initial review by the following from the template, which should help to not too easily promote them by accident if dependencies change later on: --- List of specific binary packages to be promoted to main: libmalcontent-0-0, gir1.2-malcontent-0, libpam-malcontent Specific binary packages built, but NOT to be promoted to main: malcontent, malcontent-gui, libmalcontent-ui-dev, libmalcontent-0-dev, libmalcontent-ui-1-1, gir1.2-malcontentui-1 Needs an extra-exclude: libmalcontent-ui-dev, libmalcontent-0-dev AFAIU this should unblock you, please add the respective Extra-Excludes and get the gnome change pulling this in to Oracular for the promotion to be acted on. Setting "in-progress" to match that. ** Changed in: malcontent (Ubuntu) Status: New => In Progress ** Changed in: malcontent (Ubuntu) Assignee: Christian Ehrhardt (paelzer) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
** Changed in: malcontent (Ubuntu) Assignee: (unassigned) => Christian Ehrhardt (paelzer) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
** Description changed: Availability In Universe, builds for all architectures and in sync with Debian. Rationale = Required for parental control features in GNOME. Security This will need a Security review. Quality Assurance = Package is maintained in Debian. No major bugs in Debian or Ubuntu. UI Standards Contains a graphical tool that follows GNOME UI standards. Dependencies All in main since we don't aim at promoting the UI library at this point (which is the one that Depends on libflatpak LP: #1812456) + The binary we request to promote are gir1.2-malcontent-0, + libmalcontent-0-0 and libpam-malcontent + Standards Compliance Package uses standards version 4.5.0. Maintenance === Actively developed upstream https://gitlab.freedesktop.org/pwithnall/malcontent. Packages actively maintained in Debian. Security Checks === No CVEs found in http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=malcontent. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
Please also include libpam-malcontent since that would allow to support session-max-usage time when logging in from gdm. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
Since the original MIR request malcontent got its library split in a backend and an UI part. gnome-control-center would Depends on libmalcontent-0-0 which doesn't Depends on libflatpak (libmalcontent-ui-1-1 is the one which includes that Depends). The request then is to promote only the libmalcontent-0-0 and gir1.2-malcontent-0 binaries. Since the initial review got a +1 from MIR and security teams but the promoted got blocked on universe Depends which aren't part of the request anymore can we consider the package good to promote after subcribing desktop-packages? ** Description changed: Availability In Universe, builds for all architectures and in sync with Debian. Rationale = Required for parental control features in GNOME. Security This will need a Security review. Quality Assurance = Package is maintained in Debian. No major bugs in Debian or Ubuntu. UI Standards Contains a graphical tool that follows GNOME UI standards. Dependencies - All in main except for libflatpak0 (LP: #1812456) + + All in main since we don't aim at promoting the UI library at this point + (which is the one that Depends on libflatpak LP: #1812456) Standards Compliance Package uses standards version 4.5.0. Maintenance === Actively developed upstream https://gitlab.freedesktop.org/pwithnall/malcontent. Packages actively maintained in Debian. Security Checks === No CVEs found in http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=malcontent. ** Changed in: malcontent (Ubuntu) Status: In Progress => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
What's the status here now? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
So, this seems a ack, but the libflatpak0 MIR should be dealt first. Let's put it as in progress. ** Changed in: malcontent (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
Also gnome-shell has a dynamic runtime dependency on malcontent, so in order to enable this on ubuntu we should have it in main -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
** Description changed: Availability In Universe, builds for all architectures and in sync with Debian. Rationale = Required for parental control features in GNOME. Security This will need a Security review. Quality Assurance = Package is maintained in Debian. No major bugs in Debian or Ubuntu. UI Standards Contains a graphical tool that follows GNOME UI standards. Dependencies All in main except for libflatpak0 (LP: #1812456) Standards Compliance Package uses standards version 4.5.0. Maintenance === - Actively developed upstream https://github.com/endlessm/malcontent. + Actively developed upstream https://gitlab.freedesktop.org/pwithnall/malcontent. Packages actively maintained in Debian. Security Checks === No CVEs found in http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=malcontent. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
** Changed in: malcontent (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
I subscribed the desktop team to the bugs. I'm assigning the security team now per comment #2 (thanks for the review). ** Changed in: malcontent (Ubuntu) Assignee: Robert Ancell (robert-ancell) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
> The 'malcontent-gui' binary package provides a GUI, and may need > further review from a UI perspective. to follow up; this does appear to meet the MIR UI standards of 1) being intl'ed, and 2) providing a desktop file, so this item is ok from MIR perspective. Remaining items are: This needs a team bug subscriber This does need a security review This is still dependent on libflatpak0 MIR from LP: #1812456 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
[Summary] This needs a team bug subscriber; setting back to 'incomplete' until it has a team bug subscriber. The 'malcontent-gui' binary package provides a GUI, and may need further review from a UI perspective. This does need a security review, so I'll assign ubuntu-security after the above are addressed. This is still dependent on libflatpak0 MIR from LP: #1812456 Otherwise, this is an ACK from MIR team. specific binary packages to be promoted to main: - gir1.2-malcontent-0 - gir1.2-malcontentui-0 - libmalcontent-0-0 - libmalcontent-ui-0-0 - libpam-malcontent - malcontent - malcontent-gui Notes: Required TODOs: - some team (probably foundations) must subscribe to package bugs - malcontent-gui package needs further review as part of UI - needs security team review - this does also depend on libflatpack0 MIR from LP: #1812456 [Duplication] There is no other package in main providing the same functionality. [Dependencies] OK: - other dependencies to MIR due to this: libflatpak0 is in universe, but also in progress via LP: #1812456 Problems: - -dev packages that need exclusion: libmalcontent-0-dev libmalcontent-ui-0-dev [Embedded sources and static linking] OK: - no embedded source present - no static linking [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not open a port - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop Problems: - does deal with system authentication (pam) - does parse data formats [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - translation present - not a python/go package Problems: - does not have a test suite that runs as autopkgtest - The package does not have a team bug subscriber [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking is in place - d/watch is present and looks ok - Upstream update history is good - Debian/Ubuntu update history is good but short, pkg was added recently - promoting this does not seem to cause issues for MOTUs - no massive Lintian warnings - d/rules is rather clean - Does not have Built-Using - not go Package Problems: - the current release is packaged the latest upstream release is 0.9.0 while Debian/Ubuntu have 0.8.0 however, 0.9.0 is from only 2 weeks ago [Upstream red flags] OK: - no Errors/warnings during the build (except minor annotation warnings) - no incautious use of malloc/sprintf (as far as I can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH - no use of user nobody - no use of setuid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit, seed or libgoa-* Problems: - 'malcontent-gui' package is part of the UI, needs extra checks ** Changed in: malcontent (Ubuntu) Status: New => Incomplete ** Changed in: malcontent (Ubuntu) Assignee: Dan Streetman (ddstreet) => Robert Ancell (robert-ancell) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1892456] Re: [MIR] malcontent
** Changed in: malcontent (Ubuntu) Assignee: (unassigned) => Dan Streetman (ddstreet) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1892456 Title: [MIR] malcontent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/malcontent/+bug/1892456/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
