Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

Andreas Steinmetz wrote: As posted to lkml and linux-scsi on 2007-03-15 without reply, see http://marc.info/?l=linux-kernelm=117395128412313w=2 for original post: It is not so nice when one can write backup tapes but the tapes cannot be read. I don't know if memory management or the st

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

James Bottomley wrote: On Mon, 2007-03-19 at 12:49 -0500, Mike Christie wrote: I can't even say if the tapes are written correctly as I can't read them (one does not reboot production machines back to 2.4.x just to try to read a backup tape - I don't have 2.6.x older than 2.6.20

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

Mike Christie wrote: James Bottomley wrote: On Mon, 2007-03-19 at 12:49 -0500, Mike Christie wrote: I can't even say if the tapes are written correctly as I can't read them (one does not reboot production machines back to 2.4.x just to try to read a backup tape - I don't have 2.6.x older than

Re: Multipath failover handling (Was: Re: 2.6.24-rc3-mm1)

James Bottomley wrote: However, there's still devloss_tmo to consider ... even in multipath, I don't think you want to signal path failure until devloss_tmo has fired otherwise you'll get too many transient up/down events which damage performance if the array has an expensive failover model.

Re: [PATCH] drivers/scsi/: Spelling fixes

Joe Perches wrote: Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 57ce225..3cc21f5 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -1121,7 +1121,7 @@ iscsi_send(struct iscsi_conn *conn, struct

Re: [2.6 patch] scsi_transport_iscsi.c: make 2 functions static

Adrian Bunk wrote: This patch makes the following needlessly global functions static: - __iscsi_unblock_session() - iscsi_session_state_name() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Looks good. Thanks. Acked-by: Mike Christie [EMAIL PROTECTED] -- To unsubscribe from this list: send

Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h

Michael S. Tsirkin wrote: scsi/scsi_transport_iscsi.h uses struct mutex, so while linux/mutex.h seems to be pulled in indirectly by one of the headers it includes, the right thing is to include linux/mutex.h directly. Is that part about always including the header directly right? If so then

Re: [PATCH] device-mapper: multipath hardware handler for EMC

Christoph Hellwig wrote: +/* Code borrowed from dm-lsi-rdac by Mike Christie */ Any reason that module isn't submitted? I do not have access to their HW specs, and have been busy with some iscsi things so I did not have time to finish things up. I was also hoping LSI would soon figure out

Re: [ANNOUNCE 0/6] Open-iSCSI High-Performance Initiator for Linux

Alex Aizman wrote: This is to announce Open-iSCSI project: High-Performance iSCSI Initiator for Linux. MOTIVATION == Our initial motivations for the project were: (1) implement the right user/kernel split, and (2) design iSCSI data path for performance. Recently we added (3): get accepted

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

On 07/17/2012 10:47 AM, Paolo Bonzini wrote: Il 17/07/2012 18:36, Christoph Hellwig ha scritto: There's no such thing in the market today as a removable disk that's resizeable. Removable disks are for things like backup cartridges and ageing jazz drives. Worse: most removeable devices today

Re: [PATCH] sd: do not set changed flag on all unit attention conditions

On 07/17/2012 12:45 PM, Mike Christie wrote: On 07/17/2012 10:47 AM, Paolo Bonzini wrote: Il 17/07/2012 18:36, Christoph Hellwig ha scritto: There's no such thing in the market today as a removable disk that's resizeable. Removable disks are for things like backup cartridges and ageing jazz

Re: [PATCH 5/6] scsi: replace obsolete NLMSG_* with type safe nlmsg_*

changed, 38 insertions(+), 43 deletions(-) iscsi parts are ok. I also ran some quick tests on them. Reviewed-by: Mike Christie micha...@cs.wisc.edu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] cxgb4i: Remove the scsi host device when removing device

(cdev 0x%p, unknown state %d.\n, cdev, state); Patch looks ok to me. Reviewed-by: Mike Christie micha...@cs.wisc.edu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [ANNOUNCE 0/7] Open-iSCSI/Linux-iSCSI-5 High-Performance Initiator

Dmitry Yusupov wrote: On Sat, 2005-07-30 at 15:23 -0500, James Bottomley wrote: On Sat, 2005-07-30 at 12:53 -0700, David S. Miller wrote: From: James Bottomley [EMAIL PROTECTED] Date: Sat, 30 Jul 2005 12:32:42 -0500 FIB has taken your netlink number, so I changed it to 32 MAX_LINKS is 32,

Re: [Linux-cluster] Re: [PATCH 00/14] GFS

David Teigland wrote: On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote: * Why are you using bufferheads extensively in a new filesystem? bh's are used for metadata, the log, and journaled data which need to be written at the block granularity, not page. In a scsi tree

Re: [Linux-cluster] Re: [PATCH 00/14] GFS

Mike Christie wrote: David Teigland wrote: On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote: * Why are you using bufferheads extensively in a new filesystem? bh's are used for metadata, the log, and journaled data which need to be written at the block granularity, not page

Re: [dm-devel] Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context

Mike Christie wrote: Jens Axboe wrote: On Wed, Dec 20 2006, Kiyoshi Ueda wrote: Hi Jens, On Wed, 20 Dec 2006 19:49:17 +0100, Jens Axboe [EMAIL PROTECTED] wrote: Big NACK on this - it's not only really ugly, it's also buggy to pass interrupt flags as function arguments. As you also mention

Re: [dm-devel] Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context

Jens Axboe wrote: On Wed, Dec 20 2006, Kiyoshi Ueda wrote: Hi Jens, On Wed, 20 Dec 2006 19:49:17 +0100, Jens Axboe [EMAIL PROTECTED] wrote: Big NACK on this - it's not only really ugly, it's also buggy to pass interrupt flags as function arguments. As you also mention in the 0/1 mail, this

Re: [dm-devel] Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context

Jens Axboe wrote: On Thu, Dec 21 2006, Mike Christie wrote: Or the block layer code could set up the clone too. elv_next_request could prep a clone based on the orignal request for the driver then dm would not have to worry about that part. It really can't, since it doesn't know how

Re: [dm-devel] Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context

Mike Christie wrote: Jens Axboe wrote: On Thu, Dec 21 2006, Mike Christie wrote: Or the block layer code could set up the clone too. elv_next_request could prep a clone based on the orignal request for the driver then dm would not have to worry about that part. It really can't, since

Re: [dm-devel] Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context

Jens Axboe wrote: On Thu, Dec 21 2006, Mike Christie wrote: Mike Christie wrote: Jens Axboe wrote: On Thu, Dec 21 2006, Mike Christie wrote: Or the block layer code could set up the clone too. elv_next_request could prep a clone based on the orignal request for the driver then dm would

Re: [dm-devel] Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context

Jens Axboe wrote: On Thu, Dec 21 2006, Mike Christie wrote: Jens Axboe wrote: On Thu, Dec 21 2006, Mike Christie wrote: Mike Christie wrote: Jens Axboe wrote: On Thu, Dec 21 2006, Mike Christie wrote: Or the block layer code could set up the clone too. elv_next_request could prep a clone

Re: [dm-devel] Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

Kiyoshi Ueda wrote: Hi Jens, On Thu, 21 Dec 2006 08:49:47 +0100, Jens Axboe [EMAIL PROTECTED] wrote: The new hook is needed for error handling in dm. For example, when an error occurred on a request, dm-multipath wants to try another path before returning EIO to application. Without the

Re: [RFC] SCSI target for IBM Power5 LPAR

Dave C Boutcher wrote: On Wed, Sep 07, 2005 at 12:49:32PM +0200, Christoph Hellwig wrote: On Tue, Sep 06, 2005 at 04:28:01PM -0500, Dave C Boutcher wrote: This device driver provides the SCSI target side of the virtual SCSI on IBM Power5 systems. The initiator side has been in mainline for

Re: [RFC] SCSI target for IBM Power5 LPAR

FUJITA Tomonori wrote: month. We discussed it with Christoph and decided that it would be better to start from scratch because of the design differences. Some of the things we are trying to improve upon are things that are better supported in 2.6. Some differences: - We will support

Re: [RFC] SCSI target for IBM Power5 LPAR

Vladislav Bolkhovitin wrote: Dave C Boutcher wrote: On Wed, Sep 07, 2005 at 12:49:32PM +0200, Christoph Hellwig wrote: On Tue, Sep 06, 2005 at 04:28:01PM -0500, Dave C Boutcher wrote: This device driver provides the SCSI target side of the virtual SCSI on IBM Power5 systems. The initiator

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

On 08/06/2012 12:56 PM, Bart Van Assche wrote: On 08/04/12 22:36, Mike Christie wrote: On 08/04/2012 03:18 PM, Bart Van Assche wrote: On 08/04/12 16:46, Mike Christie wrote: I think we have to have scsi-ml do a get_device when a sdev is added to the starved entry and then do a put_device when

Re: [SCSI] qla4xxx: support iscsiadm session mgmt

On 08/08/2012 10:00 AM, Dan Carpenter wrote: I never heard back on this. This buffer overflow is still present in the current code. Qlogic just sent a patch yesterday. http://marc.info/?l=linux-scsim=134434199930938w=2 regards, dan carpenter On Thu, Jun 14, 2012 at 09:27:45PM +0300,

Re: Kernel hangs in truncate_inode_pages()

On 08/24/2012 08:13 AM, Bart Van Assche wrote: Hello, If I log in with the open-iscsi initiator to an iSCSI target an power down the target the initiator hangs in truncate_inode_pages(). This happens systematically with kernel 3.6-rc3 and it's something I've never seen with kernel 3.4 or

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

On 08/02/2012 04:34 AM, James Bottomley wrote: On Thu, 2012-08-02 at 18:28 +0900, Chanho Min wrote: On Thu, Aug 2, 2012 at 5:57 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2012-08-02 at 17:41 +0900, Chanho Min wrote: This patch is to fix a oops from a torn down

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

On 08/04/2012 04:01 AM, Bart Van Assche wrote: On 08/02/12 08:41, Chanho Min wrote: This patch is to fix a oops from a torn down device. When scsi_run_queue process starved queues, scsi_request_fn can race with scsi_remove_device. In this case, rarely, scsi_request_fn release the last

Re: [PATCH] fix NULL-pointer dereference on scsi_run_queue

On 08/04/2012 03:18 PM, Bart Van Assche wrote: On 08/04/12 16:46, Mike Christie wrote: I think we have to have scsi-ml do a get_device when a sdev is added to the starved entry and then do a put_device when it is removed (must do these under the host lock for the starved entry case too). I am

Re: [PATCH] Add iSCSI iBFT support (v0.4.5)

Konrad Rzeszutek wrote: On Sunday 27 January 2008 01:01:23 you wrote: On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED] wrote: Hey Andrew, Please add this patch along with Greg KH's kobject fixes. erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.

Re: [PATCH] Add iSCSI IBFT support (v0.4.5) - fixes to the header files.

Konrad Rzeszutek wrote: +/* + * Helper functions to parse data properly. + */ +static ssize_t sprintf_ipaddr(char *buf, u8 *ip) +{ + if (ip[0] == 0 ip[1] == 0 ip[2] == 0 ip[3] == 0 + ip[4] == 0 ip[5] == 0 ip[6] == 0 ip[7] == 0 + ip[8] == 0 ip[9] == 0 ip[10] ==

Re: [2.6 patch] make __iscsi_complete_pdu() static

Adrian Bunk wrote: __iscsi_complete_pdu() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Looks good. Thanks. Acked-by: Mike Christie [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

Re: New 2.6.24.2 SG_IO SCSI problems

Mark Hounschell wrote: I seem to have run into some sort of regression in the SG_IO interface of 2.6.24.2. I have an application that up until 2.6.24 worked fine. The 2.6.23.16 kernel works fine. During reads I get these kernel messages. Writes and other functions _seem_ OK. Actually basic

Re: New 2.6.24.2 SG_IO SCSI problems

Mike Christie wrote: Mark Hounschell wrote: I seem to have run into some sort of regression in the SG_IO interface of 2.6.24.2. I have an application that up until 2.6.24 worked fine. The 2.6.23.16 kernel works fine. During reads I get these kernel messages. Writes and other functions

Re: New 2.6.24.2 SG_IO SCSI problems

Mark Hounschell wrote: Mark Hounschell wrote: Mike Christie wrote: Mike Christie wrote: Mark Hounschell wrote: I seem to have run into some sort of regression in the SG_IO interface of 2.6.24.2. I have an application that up until 2.6.24 worked fine. The 2.6.23.16 kernel works fine. During

Re: Soft lockup in scsi_remove_target under 3.6 (regression from 3.5)

On 10/02/2012 07:43 PM, Jonathan McDowell wrote: Upgraded to 3.6 today on my dev box and after seeing an FC attached SAN go down and come back up (due to an expected reboot) I started getting the following in my logs. It continues even after the array is back and functioning - I'm seeing:

Re: [PATCH][BUG] Incorrect SCSI transfer length computation from odd sized scsi_execute_async() transfers.

Jeremy Linton wrote: Any function which use scsi_execute_async() and transfers odd sized data that doesn't align correctly with the segment sizes may have its transfer length padded out to the closest segment size. For writes, this results in unnecessary data being transfered to the SCSI

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

. This patch is fine as a work-around until that gets merged, though. Actually, I think the new scsi request infrastructure should be doing the bouncing (rather than have it done in each problem path we discover). Mike Christie tells me we're missing bouncing by accident in the scsi_execute path

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

On 07/18/2013 12:51 PM, Nicholas A. Bellinger wrote: On Wed, 2013-07-17 at 18:19 +0200, Alexander Gordeev wrote: On Tue, Jul 16, 2013 at 02:38:03PM -0700, Nicholas A. Bellinger wrote: [7.927818] scsi_execute(): Calling blk_mq_free_request [7.927826] scsi 0:0:0:0: Direct-Access ATA

Re: [dm-devel] [PATCH 4/9] block: Make generic_make_request handle arbitrary sized bios

On 11/04/2013 03:36 PM, Kent Overstreet wrote: @@ -1822,6 +1820,14 @@ void generic_make_request(struct bio *bio) */ blk_queue_bounce(q, bio); + if (!blk_queue_largebios(q)) + split = blk_bio_segment_split(q, bio, q-bio_split);

Re: [PATCH 2/5] [PATCH 2/5] revert: blk-mq: blk-mq should free bios in pass through case

On 10/4/13 8:49 AM, Christoph Hellwig wrote: This patch causes boot failures when using REQ_FLUSH requests. Also the following statement in the commit log: For non mq calls, the block layer will free the bios when blk_finish_request is called. Sorry, messed up function name. I

Re: [PATCH 2/5] [PATCH 2/5] revert: blk-mq: blk-mq should free bios in pass through case

On 10/05/2013 05:50 AM, Christoph Hellwig wrote: On Fri, Oct 04, 2013 at 12:39:33PM -0500, Mike Christie wrote: Sorry, messed up function name. I meant blk_end_request*. For blk_execute_rq_nowait/blk_execute_rq and normal request use, the lower levels free the bios as they are completed

Re: SuSE O_DIRECT|O_NONBLOCK overload

On 03/12/2014 07:15 PM, NeilBrown wrote: I also think there should probably be just one FAILFAST flag. Where it was the DEV or the TRANSPORT or the DRIVER that failed could be returned in the error code for any caller that cared. But as I don't know why the one became three I could well be

Re: scsi-mq + open-iscsi support patches..?

On 10/28/13 5:03 PM, Nicholas A. Bellinger wrote: Hi Mike, Just curious as to the status of the scsi-mq conversion patches for open-iscsi that you where working on a while back..? I'm asking because recently I've been spending alot of time with scsi-mq + virtio-scsi, and would really to start

Re: Drivers: scsi: FLUSH timeout

...@parallels.com; h...@infradead.org; linux- s...@vger.kernel.org; Mike Christie Subject: Re: Drivers: scsi: FLUSH timeout On 09/21/2013 07:24 AM, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, September 20, 2013 1:32 PM To: KY Srinivasan

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

On 07/18/2013 06:23 PM, Nicholas A. Bellinger wrote: Just saw this while trying out iscsi with the scsi-mq stuff :) Took at stab at this a while back, but ended getting distracted on other items. Do you have an initial conversion running yet..? Not running well :) Have a patch but I am

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

-by: Mike Christie micha...@cs.wisc.edu diff --git a/block/blk-flush.c b/block/blk-flush.c index c56c37d..3e4cc9c 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -231,7 +231,7 @@ static void flush_end_io(struct request *flush_rq, int error) unsigned long flags = 0; if (q

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

On 06/04/2014 12:15 PM, KY Srinivasan wrote: -Original Message- From: James Bottomley [mailto:jbottom...@parallels.com] Sent: Wednesday, June 4, 2014 10:02 AM To: KY Srinivasan Cc: linux-kernel@vger.kernel.org; a...@canonical.com; de...@linuxdriverproject.org; h...@infradead.org;

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

On 6/5/14, 9:53 PM, KY Srinivasan wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Thursday, June 5, 2014 6:33 PM To: KY Srinivasan Cc: James Bottomley; linux-kernel@vger.kernel.org; a...@canonical.com; de...@linuxdriverproject.org; h...@infradead.org

Re: [ANNOUNCE] scsi patch queue tree

On 05/28/2014 05:54 AM, Christoph Hellwig wrote: be2iscsi: Fix processing cqe for cxn whose endpoint is freed I didn't look at your tree, but when this patch was posted on the list I think it had a bug. http://www.spinics.net/lists/linux-scsi/msg74191.html -- To unsubscribe from this

Re: [ANNOUNCE] scsi patch queue tree

On 05/28/2014 10:50 AM, Christoph Hellwig wrote: On Wed, May 28, 2014 at 10:37:31AM -0500, Mike Christie wrote: On 05/28/2014 05:54 AM, Christoph Hellwig wrote: be2iscsi: Fix processing cqe for cxn whose endpoint is freed I didn't look at your tree, but when this patch was posted

Re: [PATCH] iscsi: fix wrong order of opcode and itt in iscsi_handle_reject prompt

0x%x\n, rejected_pdu.opcode, + rejected_pdu.itt, reject-reason); break; } return rc; Thanks. Acked-by: Mike Christie micha...@cs.wisc.edu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] iscsi: conn error (1020) each time iscsi session logout

On 12/18/2013 12:47 AM, Vaughan Cao wrote: We do a normal login/logout process to iscsi server. iscsiadm report success, but we always see the following error just before conn shutdown in dmesg. Oct 15 05:30:09 vmhodtest019 iscsid: Connection1:0 to [target:

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

On 12/10/13 8:11 AM, Konrad Rzeszutek Wilk wrote: Ethan Zhao ethan.ker...@gmail.com wrote: Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit() ibft_cleanup()

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

. To do that, we would need to make kset's list a klist and add some iterators then modify iscsi_boot_sysfs.c and iscsi_ibft.c to use them instead of using the iscsi_boot_kset-kobj_list. I will work on a patch to do this. But for now your patch is ok. Reviewed-by: Mike Christie micha...@cs.wisc.edu

Re: [PATCH v3] scsi: bnx2i: bnx2i_iscsi.c: Fix variable which was set to the wrong value

of the array. This patch fixes bnx2i and be2iscsi's setting of the custom stats. They both just have the one, eh_abort_cnt, so that should be in the first entry of the custom array and custom_length should then be one. Signed-off-by: Mike Christie micha...@cs.wisc.edu Acked-by: Eddie Wai eddie

Re: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

all issues. [PATCH] qla4xxx/iscsi: fix get_host_stats error propagation This patch fixes 2 bugs. 1. qla4xxx was not always returning -EXYZ error codes when qla4xxx_get_host_stats failed. 2. iscsi_get_host_stats was dropping the error code returned by drivers like qla4xxx. Signed-off-by: Mike

Re: [PATCH 3.15 099/139] libiscsi, iser: Adjust data_length to include protection information

task as they are not always true and somewhat redundant anyway. Signed-off-by: Sagi Grimberg sa...@mellanox.com Reviewed-by: Mike Christie micha...@cs.wisc.edu Acked-by: Mike Christie micha...@cs.wisc.edu Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Signed-off-by: Greg Kroah

Re: [PATCH] Fix the arguments order of a few iscsi_conn_printk() calls

On 02/07/2014 10:18 AM, Michele Baldessari wrote: A few places had the opcode and itt arguments reversed. Fix the order. Reported-by: Josef Moellers josef.moell...@ts.fujitsu.com Signed-off-by: Michele Baldessari mich...@acksyn.org Thanks. I just acked a patch to do the same:

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

On 07/26/2014 11:21 AM, Christoph Hellwig wrote: Here's a formal one. James, can I get your signoff for it? Vladimir, can I get a reviewed-by from you (or anyone else)? --- From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001 From: James Bottomley

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

On 06/25/2014 11:52 AM, Christoph Hellwig wrote: +static int scsi_queue_rq(struct blk_mq_hw_ctx *hctx, struct request *req) +{ + struct request_queue *q = req-q; + struct scsi_device *sdev = q-queuedata; + struct Scsi_Host *shost = sdev-host; + struct scsi_cmnd *cmd =

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

On 08/27/2014 09:31 AM, Hannes Reinecke wrote: On 08/19/2014 07:54 PM, Christoph Hellwig wrote: On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote: The host asks the guest to scan when a LUN is removed or added. The only way a guest can identify the removed LUN is when an I/O is

Re: [PATCH 6/6] scsi: handle more device handler setup/teardown in common code

On 10/19/2014 11:00 AM, Christoph Hellwig wrote: -static int rdac_bus_attach(struct scsi_device *sdev) +static struct scsi_dh_data *rdac_bus_attach(struct scsi_device *sdev) { struct rdac_dh_data *h; - unsigned long flags; int err; char array_name[ARRAY_LABEL_LEN];

Re: [PATCH] iscsi_ibft: filter null v4-mapped v6 addresses

, we should accommodate the behavior of the tianocore iSCSI driver as it's already in the wild in a large number of servers. Tested under qemu using an OVMF build of tianocore EDK2. Signed-off-by: Chris Leech cle...@redhat.com Looks ok to me. Reviewed-by: Mike Christie micha...@cs.wisc.edu

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

On 11/07/2015 04:23 AM, Christoph Hellwig wrote: > On Wed, Nov 04, 2015 at 10:53:39AM -0600, Mike Christie wrote: >>> If you have to touch submit_bio() and submit_bio_wait(), how about >>> requiring the callers of these functions to set the cmd and flags >>>

Re: [dm-devel] [PATCH 19/32] block: add helper to get data dir from op

On 11/04/2015 04:44 PM, Bart Van Assche wrote: > On 11/04/2015 02:08 PM, mchri...@redhat.com wrote: >> From: Mike Christie <mchri...@redhat.com> >> >> In later patches the op will no longer be a bitmap, so we will >> not have REQ_WRITE set for all non reads like

Re: [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs

On 11/04/2015 10:49 AM, Bart Van Assche wrote: > Hello Mike, > > If you have to touch submit_bio() and submit_bio_wait(), how about > requiring the callers of these functions to set the cmd and flags > arguments in the bio structure and to leave out the cmd and flags > arguments from the

Re: [dm-devel] [PATCH 0/15] copy offload patches

On 12/10/2015 04:33 PM, Martin K. Petersen wrote: >> "Mikulas" == Mikulas Patocka writes: > > Mikulas, > > Mikulas> This patch series adds copy offload (the XCOPY command) to the > Mikulas> block layer, SCSI subsystems and device mapper. > > Now that the VFS stuff

Re: [PATCH 28/45] target: use bio op accessors

On 06/06/2016 01:46 AM, Hannes Reinecke wrote: > On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: >> From: Mike Christie <mchri...@redhat.com> >> >> Separate the op from the rq_flag_bits and have the target layer >> set/get the bio using bio_set_op_attrs/

Re: [PATCH 00/35 v4] separate operations from flags in the bio/request structs

On 02/29/2016 11:13 AM, Christoph Hellwig wrote: > Any reason you've dropped my ACK for the previous version? Sorry. I think I accidentally dropped it when I rebased back over to linux-next. It looks like it only got stuck on the first patch. I will fix that up on the resend for those kbuild

Re: [dm-devel] [PATCH 22/26] iscsi_tcp: Use ahash

-- > drivers/scsi/iscsi_tcp.h|4 +-- > drivers/scsi/libiscsi_tcp.c | 29 +-- > include/scsi/libiscsi_tcp.h | 13 +- > 4 files changed, 58 insertions(+), 42 deletions(-) > iSCSI parts look ok. Reviewed-by: Mike Christie <micha...@cs.wisc.edu>

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On 02/12/2016 11:54 AM, James Bottomley wrote: > On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: >> The scsi_transport_iscsi module already uses the ida_simple >> routines for managing the target ID, if requested to do >> so. This change replaces an ever-increasing atomic integer >> that

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On 02/15/2016 12:26 PM, Chris Leech wrote: > On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: >> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: >>> The scsi_transport_iscsi module already uses the ida_simple >>> routines for managing the target ID, if requested to do >>> so.

Re: [PATCH 1/6] block: ensure we don't truncate top bits of the request command flags

On 03/22/2016 02:01 PM, Jens Axboe wrote: > On 03/22/2016 12:59 PM, Christoph Hellwig wrote: >> On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote: >>> Some of the flags that we want to use from the make_request_fn path >>> are now larger than 32-bit, so change the functions involved to

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

On 05/03/2016 03:44 PM, Jeff Moyer wrote: > mchri...@redhat.com writes: > >> The following patches begin to cleanup the request->cmd_flags and >> bio->bi_rw mess. We currently use cmd_flags to specify the operation, >> attributes and state of the request. For bi_rw we use it for similar >> info

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

On 05/04/2016 12:58 PM, Jeff Moyer wrote: > Mike Christie <mchri...@redhat.com> writes: > >> On 05/03/2016 03:44 PM, Jeff Moyer wrote: >>> Hi, Mike, >>> >>> That git tree doesn't seem to exist. I did manage to apply your patch >>> set on to

Re: [PATCH 41/42] block: do not use REQ_FLUSH for tracking flush support

On 04/15/2016 05:50 AM, Juergen Gross wrote: > On 15/04/16 12:40, mchri...@redhat.com wrote: >> From: Mike Christie <mchri...@redhat.com> >> >> The last patch added a REQ_OP_FLUSH for request_fn drivers >> and the next patch renames REQ_FLUSH to REQ_PREFLUSH whic

Re: [PATCH 37/45] drivers: use req op accessor

On 08/03/2016 07:30 PM, Shaun Tancheff wrote: > On Wed, Aug 3, 2016 at 6:47 PM, Mike Christie <mchri...@redhat.com> wrote: >> On 08/03/2016 05:33 PM, Ross Zwisler wrote: >>> On Sun, Jun 5, 2016 at 1:32 PM, <mchri...@redhat.com> wrote: >>>>

Re: [PATCH 42/45] block, fs, drivers: remove REQ_OP compat defs and related code

On 08/03/2016 11:25 AM, Ross Zwisler wrote: > run fstests generic/008 at 2016-08-03 09:54:56 > page:ea0017af04c0 count:3 mapcount:0 mapping:8805eb059200 index:0x0 > flags: 0x3fff802828(uptodate|lru|private|writeback) > page dumped because: VM_BUG_ON_PAGE(!PageLocked(page)) >

Re: [PATCH 37/45] drivers: use req op accessor

On 08/03/2016 05:33 PM, Ross Zwisler wrote: > On Sun, Jun 5, 2016 at 1:32 PM, <mchri...@redhat.com> wrote: >> From: Mike Christie <mchri...@redhat.com> >> >> The req operation REQ_OP is separated from the rq_flag_bits >> definition. This converts the bloc

Re: [PATCH] target/user: Add daynmic growing data area feature support

On 02/22/2017 02:32 PM, Andy Grover wrote: > On 02/17/2017 01:24 AM, lixi...@cmss.chinamobile.com wrote: >> > From: Xiubo Li >> > >> > Currently for the TCMU, the ring buffer size is fixed to 64K cmd >> > area + 1M data area, and this will be bottlenecks for high

Re: [PATCH] target/user: Add daynmic growing data area featuresupport

On 02/27/2017 07:22 PM, Xiubo Li wrote: > Hi Mike > > Thanks verrry much for your work and test cases. > > > From: Xiubo Li > > Currently for the TCMU, the ring buffer size is fixed to 64K cmd > area + 1M data area, and this will be bottlenecks for

Re: ERROR: "__ucmpdi2" [drivers/scsi/sd_mod.ko] undefined!

Adding Steven and adi-buildroot-devel list. On 09/04/2016 12:12 PM, kbuild test robot wrote: > Hi Mike, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 9ca581b50dab6103183396852cc08e440fcda18e > commit:

Re: [PATCHv2] MAINTAINERS: Update open-iscsi maintainers

sertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 01bff8ea28d8..81384a2562e7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6448,10 +6448,10 @@ S:Maintained > F: drivers/firmware/iscsi_ibft* > > ISCSI > -M: Mike Christie <m

Re: [PATCH] target/user: Fix use-after-free cmd->se_cmd if the cmd is expired

On 01/03/2017 02:46 AM, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > This is another use-after-free bug, the crash Call Trace is like: > [ 368.909498] RIP: 0010:[] [] > memcpy+0x16/0x110 > .. > [ 368.909547] Call Trace: > [ 368.909550] []

Re: [PATCH] target: make device_mutex and device_list static

t; > #include "target_core_ua.h" > > -DEFINE_MUTEX(device_mutex); > -LIST_HEAD(device_list); > +static DEFINE_MUTEX(device_mutex); > +static LIST_HEAD(device_list); > static DEFINE_IDR(devices_idr); > > static struct se_hba *lun0_hba; > My fault. Thanks. Reviewed-by: Mike Christie <mchri...@redhat.com>

Re: [PATCH v6 2/2] tcmu: Add global data block pool support

On 04/26/2017 01:25 AM, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > For each target there will be one ring, when the target number > grows larger and larger, it could eventually runs out of the > system memories. > > In this patch for each target ring,

Re: [PATCH] iscsi-target: Fix initial login PDU asynchronous socket close OOPs

Thanks for the patch. On 05/26/2017 12:32 AM, Nicholas A. Bellinger wrote: > > - state = iscsi_target_sk_state_check(sk); > - write_unlock_bh(>sk_callback_lock); > - > - pr_debug("iscsi_target_sk_state_change: state: %d\n", state); > + orig_state_change(sk); > > -

Re: [PATCH] tcmu: Add fifo type waiter list support to avoid starvation

On 05/04/2017 09:51 PM, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > The fifo type waiter list will hold the udevs who are waiting for the > blocks from the data global pool. The unmap thread will try to feed the > first udevs in waiter list, if the

[PATCH 1/1] uio: Fix uio_device memory leak

, but did not see any type of device like this though. If this is a bug, this patch, made over Linus's tree, fixes the problems by just allocating the uio_device with the uio_info struct since they need to be allocated/freed/accessed at the same times. Signed-off-by: Mike Christie <mchri...@redhat.

Re: [PATCH] iscsi-target: Fix initial login PDU asynchronous socket close OOPs

On 05/30/2017 11:58 PM, Nicholas A. Bellinger wrote: > Hey MNC, > > On Fri, 2017-05-26 at 22:14 -0500, Mike Christie wrote: >> Thanks for the patch. >> > > Btw, after running DATERA's internal longevity and scale tests across > ~20 racks on v4.1.y with th

Re: [PATCH 1/1] uio: Fix uio_device memory leak

On 06/13/2017 09:01 AM, Greg KH wrote: > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: >> It looks like there might be 2 issues with the uio_device allocation, or it >> looks like we are leaking the device for possibly a specific type of device >> case

Re: [PATCH 1/1] uio: Fix uio_device memory leak

On 06/13/2017 07:16 PM, Mike Christie wrote: > On 06/13/2017 09:01 AM, Greg KH wrote: >> > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: >>> >> It looks like there might be 2 issues with the uio_device allocation, or >>> >> it &

Re: [PATCH v6 2/2] tcmu: Add global data block pool support

On 04/30/2017 06:29 AM, Xiubo Li wrote: > [...] >>> +static struct page *tcmu_try_get_block_page(struct tcmu_dev *udev, >>> uint32_t dbi) >>> +{ >>> +struct page *page; >>> +int ret; >>> + >>> +mutex_lock(>cmdr_lock); >>> +page = tcmu_get_block_page(udev, dbi); >>> +if

Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area featuresupport

On 04/30/2017 05:22 AM, Xiubo Li wrote: > On 2017年04月30日 13:48, Mike Christie wrote: >> On 04/26/2017 01:25 AM, lixi...@cmss.chinamobile.com wrote: >>> for_each_sg(data_sg, sg, data_nents, i) { >>> @@ -275,22 +371,26 @@ static void alloc_and_scatter_data_are

Re: [PATCH v6 1/2] tcmu: Add dynamic growing data area feature support

On 04/26/2017 01:25 AM, lixi...@cmss.chinamobile.com wrote: > for_each_sg(data_sg, sg, data_nents, i) { > @@ -275,22 +371,26 @@ static void alloc_and_scatter_data_area(struct tcmu_dev > *udev, > from = kmap_atomic(sg_page(sg)) + sg->offset; > while (sg_remaining

Re: [PATCH] tcmu: Recalculate the tcmu_cmd size to save cmd area memories

culate them again when it make sure > how many iovs is needed before insert it to cmd area. > > Signed-off-by: Xiubo Li <lixi...@cmss.chinamobile.com> Looks ok to me. Thanks. Acked-by: Mike Christie <mchri...@redhat.com>

  1   2   3   >