DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/248370
Change subject: Include sequences in the command help dialog
..
Include sequences in the command help dialog
The command help dialog
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/248373
Change subject: Add mediawiki-specific sequences to the command help dialog
..
Add mediawiki-specific sequences to the command help dialog
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249785
Change subject: Make jsonlint ignore more node_modules
..
Make jsonlint ignore more node_modules
Right now jsonlint only ignores the
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/249883
Change subject: Update VE core submodule to master (be148ae)
..
Update VE core submodule to master (be148ae)
New changes:
7380244 [BREAKING
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252361
Change subject: TitleSearchWidget: Only update results if the query is current
..
TitleSearchWidget: Only update results if the query is
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/253059
Change subject: TitledElement: Behave like its docs say it should
..
TitledElement: Behave like its docs say it should
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/253055
Change subject: Add ve.ui.AnnotationContextItem
..
Add ve.ui.AnnotationContextItem
Some context items appear on annotations. For them,
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252613
Change subject: Better faking of onselectionchange
..
Better faking of onselectionchange
Improve our faking by having fake selectionchange
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252592
Change subject: [WIP] TitleSearchWidget: Use OO.ui.mixin.RequestManager
..
[WIP] TitleSearchWidget: Use OO.ui.mixin.RequestManager
Get that
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252388
Change subject: Refactor LookupElement to extract the request lifecycle handling
..
Refactor LookupElement to extract the request lifecycle
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/252124
Change subject: Watch for hashchance on the demo
..
Watch for hashchance on the demo
Change-Id: Iff3284eaf202a92bc5db9bb00c9e31bf9008ca28
---
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250646
Change subject: Forcibly trigger a selection when using a Tool, to close
inspectors
..
Forcibly trigger a selection when using a Tool, to
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250881
Change subject: [BREAKING CHANGE] Create CommandHelpRegistry for
CommandHelpDialog
..
[BREAKING CHANGE] Create CommandHelpRegistry for
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251006
Change subject: MWCommandHelpDialog: udpate for core changes
..
MWCommandHelpDialog: udpate for core changes
Also: update VE core submodule
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250904
Change subject: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool
..
Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool
We have
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/244373
Change subject: Remove the "Open" button from link inspectors
..
Remove the "Open" button from link inspectors
Making consistent with the
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246702
Change subject: Run renderContents before finding nodes by offset
..
Run renderContents before finding nodes by offset
This cleans up places
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247519
Change subject: ce.Surface afterKeyDown to better cope with adjacent grouped
nodes
..
ce.Surface afterKeyDown to better cope with adjacent
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/257907
Change subject: Make clear button on numbered external links remove the node
..
Make clear button on numbered external links remove the node
DLynch has submitted this change and it was merged.
Change subject: Fix more typos
..
Fix more typos
Add a common ones (found in multiple repos) to typos.json.
Change-Id: I6b787fcc3d6e7db2876f2a8d463125d4b8190644
---
M
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/257960
Change subject: Switch numbered link context to "delete" instead of "clear"
..
Switch numbered link context to "delete" instead of "clear"
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/257041
Change subject: LinearDeleteKeyHandler: cope better with aliens
..
LinearDeleteKeyHandler: cope better with aliens
Expand the test suite so
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/259216
Change subject: Annotation context items: expand the selection if no annotations
..
Annotation context items: expand the selection if no
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258936
Change subject: Fragment delete: handle a document with no valid content offsets
..
Fragment delete: handle a document with no valid content
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/262725
Change subject: ve.ce.minImgDataUri was considered invalid in Safari
..
ve.ce.minImgDataUri was considered invalid in Safari
...so use a
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/262847
Change subject: Stop using broken image links in tests
..
Stop using broken image links in tests
They make it a little bit more cluttered to
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260057
Change subject: Initial cursor position: outside any nails
..
Initial cursor position: outside any nails
Place the initial cursor outside any
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255474
Change subject: isBlockedTrigger should use meta+ for macs, not cmd+
..
isBlockedTrigger should use meta+ for macs, not cmd+
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255482
Change subject: Add cmd+[ / cmd+] as extra bindings for indent/outdent trigger
..
Add cmd+[ / cmd+] as extra bindings for indent/outdent
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255494
Change subject: Collapse table selection when pressing escape
..
Collapse table selection when pressing escape
This only matters for merged
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255461
Change subject: Change behavior of keydownhandler execution
..
Change behavior of keydownhandler execution
Now returns whether it thinks it
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/255160
Change subject: When the cursor is inside a table cell, tab moves between cells
..
When the cursor is inside a table cell, tab moves between
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/254613
Change subject: Add ve.ce.Surface selectActiveLinkContents
..
Add ve.ce.Surface selectActiveLinkContents
Provides a way to force the
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/254615
Change subject: When adding a label to a numbered link, force the selection
..
When adding a label to a numbered link, force the selection
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/254195
Change subject: Limit the height of fragment inspectors
..
Limit the height of fragment inspectors
Fragment inspectors can currently grow to
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/293332
Change subject: Decode encoded link titles when generating them from text
..
Decode encoded link titles when generating them from text
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/293531
Change subject: ProcessDialog: Change DOM ordering of actions
..
ProcessDialog: Change DOM ordering of actions
Absolute positioning means
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294524
Change subject: DesktopContext: Positioning a maybe-floated not-embeddable popup
..
DesktopContext: Positioning a maybe-floated not-embeddable
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/264098
Change subject: Links in focusableNodes: shouldn't look clickable
..
Links in focusableNodes: shouldn't look clickable
Not using
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/269449
Change subject: [WIP] Subdocuments: Current uses of Document are contained in a
DocumentSet
..
[WIP] Subdocuments: Current uses of Document
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268437
Change subject: Don't just rely on jQuery width / height for hasRendering
..
Don't just rely on jQuery width / height for hasRendering
jQuery
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268131
Change subject: VE demo: allow saving some markup to localStorage for testing
..
VE demo: allow saving some markup to localStorage for testing
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/272999
Change subject: GeneratedContentNode: Check model existence before using
..
GeneratedContentNode: Check model existence before using
Hard to
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273931
Change subject: oojs-ui.styles is now oojs-ui-core.styles
..
oojs-ui.styles is now oojs-ui-core.styles
Bug: T127742
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273923
Change subject: MWMediaDialog: Only cache relevant information
..
MWMediaDialog: Only cache relevant information
Trim the cached image data
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273938
Change subject: Use throttle instead of debounce for find/replace rendering
..
Use throttle instead of debounce for find/replace rendering
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/272510
Change subject: LinkContextItem: add a button to select the entire label
..
LinkContextItem: add a button to select the entire label
Adds a
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/266265
Change subject: Remove uses of plain .contentEditable
..
Remove uses of plain .contentEditable
Browsers handle the inheritance via
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276517
Change subject: AnnotationContextItem: refactor applying a change to the
annotation
..
AnnotationContextItem: refactor applying a change to
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281691
Change subject: Avoid error when cite is missing a templateName in the config
map
..
Avoid error when cite is missing a templateName in the
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/282964
Change subject: ve.ui.TabbableElements: JS replacement for unreliable tabIndex
..
ve.ui.TabbableElements: JS replacement for unreliable
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/278284
Change subject: LinkAnnotationInspector: add a button to edit the label
..
LinkAnnotationInspector: add a button to edit the label
Adds a
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279387
Change subject: Template Dialog: pushPending while the dialog is closing
..
Template Dialog: pushPending while the dialog is closing
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279134
Change subject: LinearArrowKeyDownHandler: test more
..
LinearArrowKeyDownHandler: test more
Bug: T130389
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/278027
Change subject: core: Add tests for throttle
..
core: Add tests for throttle
Change-Id: Ifaae9899b020848afa07d455347c8b06f114ba14
---
M
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/274453
Change subject: FindAndReplaceDialog: don't use tabindex
..
FindAndReplaceDialog: don't use tabindex
`tabindex is a global attribute. Letting
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/274984
Change subject: Dialog: trigger the primary action with ctrl-enter
..
Dialog: trigger the primary action with ctrl-enter
If a dialog has
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/274145
Change subject: FocusableNode: forcibly update the active link on click
..
FocusableNode: forcibly update the active link on click
Selecting
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/275913
Change subject: Add throttle to complement debounce
..
Add throttle to complement debounce
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/280677
Change subject: LinearArrowKeyDownHandler: more tests
..
LinearArrowKeyDownHandler: more tests
Bug: T130389
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/280680
Change subject: [Failing] Test cases for cursoring off focused block nodes with
shift
..
[Failing] Test cases for cursoring off focused block
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279961
Change subject: MWLinkAnnotationInspector: select entire link when switching
tabs
..
MWLinkAnnotationInspector: select entire link when
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281462
Change subject: Use "publish" instead of "save" in toolbar and save-dialog
..
Use "publish" instead of "save" in toolbar and save-dialog
Bug:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281456
Change subject: Give the active link annotation inline-block
..
Give the active link annotation inline-block
This fixes an issue where
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/285421
Change subject: Dialog: When reusing a reference, avoid popping up the group
menu
..
Dialog: When reusing a reference, avoid popping up the
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/287972
Change subject: Insert undo breakpoints at word breaks
..
Insert undo breakpoints at word breaks
When users interact with the contenteditable
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/284221
Change subject: ce.Surface: Convenience function for selecting node contents
..
ce.Surface: Convenience function for selecting node contents
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/284223
Change subject: Select the label properly when converting LinkNode to
LinkAnnotation
..
Select the label properly when converting LinkNode to
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/284481
Change subject: OutlineOptionWidget mediawiki theme: icons the correct size
..
OutlineOptionWidget mediawiki theme: icons the correct size
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/301629
Change subject: MWLinkAnnotationInspector: change where auto switch to external
occurs
..
MWLinkAnnotationInspector: change where auto switch
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304280
Change subject: Centralize some checks for unmodified left clicks
..
Centralize some checks for unmodified left clicks
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304313
Change subject: Update VE core submodule to master (f1fa096)
..
Update VE core submodule to master (f1fa096)
New changes:
a3ca325 Use OO.ui
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304279
Change subject: Use OO.ui constants for mouse buttons
..
Use OO.ui constants for mouse buttons
Also adds a helper for checking whether a
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/303820
Change subject: BranchNote: make block slug contenteditable=false
..
BranchNote: make block slug contenteditable=false
It's possible to
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/303956
Change subject: LinkAnnotationInspector: add a "label" field
..
LinkAnnotationInspector: add a "label" field
This field will allow the link
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304594
Change subject: Dialog must listen for changes to the param names
..
Dialog must listen for changes to the param names
Otherwise the second
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304575
Change subject: ve.ce.Surface: when setting selection just focus if focusTarget
== activeElement
..
ve.ce.Surface: when setting selection
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304487
Change subject: Flag the help button as progressive
..
Flag the help button as progressive
This gives it visual indicators that it'll take
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300309
Change subject: TabIndexScope: skipAriaHidden not respected, and applied to
FragmentDialog
..
TabIndexScope: skipAriaHidden not respected,
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299779
Change subject: MWSaveDialog: Give checkboxes a class based on their origin's
name
..
MWSaveDialog: Give checkboxes a class based on their
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299190
Change subject: Move internal-link detection into the
InternalLinkAnnotationWidget
..
Move internal-link detection into the
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297804
Change subject: TabIndexScope: respect aria-hidden
..
TabIndexScope: respect aria-hidden
Bug: T129792
Bug: T129791
Change-Id:
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297608
Change subject: Window: make the focus trap smarter
..
Window: make the focus trap smarter
Current behavior will always focus the content
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297424
Change subject: TitleOptionWidget: don't subvert OptionWidget's tabindex
..
TitleOptionWidget: don't subvert OptionWidget's tabindex
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/303505
Change subject: ce.Surface: only change selection during CleanupUnicorns if
it's in the document
..
ce.Surface: only change selection during
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335257 )
Change subject: Dialog: meta as well as ctrl for modifier on enter
..
Dialog: meta as well as ctrl for modifier on enter
This is consistent
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/335462 )
Change subject: DesktopArticleTarget: wait for global.js as well
..
DesktopArticleTarget: wait for global.js as well
Bug: T156899
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336439 )
Change subject: ArticleTarget: try to refresh editToken if getWikitextFragment
fails
..
ArticleTarget: try to refresh editToken if
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333666 )
Change subject: DatetimeAnnotation: flesh out model with datetime attribute
..
DatetimeAnnotation: flesh out model with datetime attribute
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334373 )
Change subject: MWSaveDialog: only focus summary if we're on the save panel
..
MWSaveDialog: only focus summary if we're on the save panel
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334151 )
Change subject: Advanced Settings: prefill current page title when enabling
displaytitle
..
Advanced Settings: prefill current page title
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/337610 )
Change subject: DesktopArticleTarget.init: Don't hardcode single-tab accesskey
..
DesktopArticleTarget.init: Don't hardcode single-tab
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336844 )
Change subject: ve.ui.Surface: fix issues with scrolling while selection
..
ve.ui.Surface: fix issues with scrolling while selection
Rely
DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/338134 )
Change subject: MWSaveDialog: Switch to save panel when showing message
..
MWSaveDialog: Switch to save panel when showing message
Fixing
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306044
Change subject: init: port in isUnModifiedLeftClick without any VE core
dependencies
..
init: port in isUnModifiedLeftClick without any VE
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306240
Change subject: init: Don't set an invalid progress state when loading
..
init: Don't set an invalid progress state when loading
Bug: T143160
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307533
Change subject: getNodeAndOffset: check whether the node has a view before
using it
..
getNodeAndOffset: check whether the node has a view
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307782
Change subject: ce.TableRowNode: check we're still attached in setupMissingCell
..
ce.TableRowNode: check we're still attached in
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309352
Change subject: TableKeyDownHandler: return early if any modifier other than
shift is used
..
TableKeyDownHandler: return early if any
DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313428
Change subject: Decode likely URLs before sending them to citoid
..
Decode likely URLs before sending them to citoid
The citoid service seems
1 - 100 of 255 matches
Mail list logo