[MediaWiki-commits] [Gerrit] Include sequences in the command help dialog - change (VisualEditor/VisualEditor)

2015-10-23 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/248370 Change subject: Include sequences in the command help dialog .. Include sequences in the command help dialog The command help dialog

[MediaWiki-commits] [Gerrit] Add mediawiki-specific sequences to the command help dialog - change (mediawiki...VisualEditor)

2015-10-23 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/248373 Change subject: Add mediawiki-specific sequences to the command help dialog .. Add mediawiki-specific sequences to the command help dialog

[MediaWiki-commits] [Gerrit] Make jsonlint ignore more node_modules - change (mediawiki...VisualEditor)

2015-10-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/249785 Change subject: Make jsonlint ignore more node_modules .. Make jsonlint ignore more node_modules Right now jsonlint only ignores the

[MediaWiki-commits] [Gerrit] Update VE core submodule to master (be148ae) - change (mediawiki...VisualEditor)

2015-10-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/249883 Change subject: Update VE core submodule to master (be148ae) .. Update VE core submodule to master (be148ae) New changes: 7380244 [BREAKING

[MediaWiki-commits] [Gerrit] TitleSearchWidget: Only update results if the query is current - change (mediawiki/core)

2015-11-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/252361 Change subject: TitleSearchWidget: Only update results if the query is current .. TitleSearchWidget: Only update results if the query is

[MediaWiki-commits] [Gerrit] TitledElement: Behave like its docs say it should - change (oojs/ui)

2015-11-13 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/253059 Change subject: TitledElement: Behave like its docs say it should .. TitledElement: Behave like its docs say it should Change-Id:

[MediaWiki-commits] [Gerrit] Add ve.ui.AnnotationContextItem - change (VisualEditor/VisualEditor)

2015-11-13 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/253055 Change subject: Add ve.ui.AnnotationContextItem .. Add ve.ui.AnnotationContextItem Some context items appear on annotations. For them,

[MediaWiki-commits] [Gerrit] Better faking of onselectionchange - change (VisualEditor/VisualEditor)

2015-11-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/252613 Change subject: Better faking of onselectionchange .. Better faking of onselectionchange Improve our faking by having fake selectionchange

[MediaWiki-commits] [Gerrit] [WIP] TitleSearchWidget: Use OO.ui.mixin.RequestManager - change (mediawiki/core)

2015-11-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/252592 Change subject: [WIP] TitleSearchWidget: Use OO.ui.mixin.RequestManager .. [WIP] TitleSearchWidget: Use OO.ui.mixin.RequestManager Get that

[MediaWiki-commits] [Gerrit] Refactor LookupElement to extract the request lifecycle hand... - change (oojs/ui)

2015-11-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/252388 Change subject: Refactor LookupElement to extract the request lifecycle handling .. Refactor LookupElement to extract the request lifecycle

[MediaWiki-commits] [Gerrit] Watch for hashchance on the demo - change (VisualEditor/VisualEditor)

2015-11-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/252124 Change subject: Watch for hashchance on the demo .. Watch for hashchance on the demo Change-Id: Iff3284eaf202a92bc5db9bb00c9e31bf9008ca28 ---

[MediaWiki-commits] [Gerrit] Forcibly trigger a selection when using a Tool, to close ins... - change (VisualEditor/VisualEditor)

2015-11-02 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/250646 Change subject: Forcibly trigger a selection when using a Tool, to close inspectors .. Forcibly trigger a selection when using a Tool, to

[MediaWiki-commits] [Gerrit] [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelp... - change (VisualEditor/VisualEditor)

2015-11-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/250881 Change subject: [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog .. [BREAKING CHANGE] Create CommandHelpRegistry for

[MediaWiki-commits] [Gerrit] MWCommandHelpDialog: udpate for core changes - change (mediawiki...VisualEditor)

2015-11-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/251006 Change subject: MWCommandHelpDialog: udpate for core changes .. MWCommandHelpDialog: udpate for core changes Also: update VE core submodule

[MediaWiki-commits] [Gerrit] Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool - change (VisualEditor/VisualEditor)

2015-11-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/250904 Change subject: Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool .. Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool We have

[MediaWiki-commits] [Gerrit] Remove the "Open" button from link inspectors - change (VisualEditor/VisualEditor)

2015-10-07 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/244373 Change subject: Remove the "Open" button from link inspectors .. Remove the "Open" button from link inspectors Making consistent with the

[MediaWiki-commits] [Gerrit] Run renderContents before finding nodes by offset - change (VisualEditor/VisualEditor)

2015-10-15 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/246702 Change subject: Run renderContents before finding nodes by offset .. Run renderContents before finding nodes by offset This cleans up places

[MediaWiki-commits] [Gerrit] ce.Surface afterKeyDown to better cope with adjacent grouped... - change (VisualEditor/VisualEditor)

2015-10-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/247519 Change subject: ce.Surface afterKeyDown to better cope with adjacent grouped nodes .. ce.Surface afterKeyDown to better cope with adjacent

[MediaWiki-commits] [Gerrit] Make clear button on numbered external links remove the node - change (mediawiki...VisualEditor)

2015-12-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/257907 Change subject: Make clear button on numbered external links remove the node .. Make clear button on numbered external links remove the node

[MediaWiki-commits] [Gerrit] Fix more typos - change (VisualEditor/VisualEditor)

2015-12-09 Thread DLynch (Code Review)
DLynch has submitted this change and it was merged. Change subject: Fix more typos .. Fix more typos Add a common ones (found in multiple repos) to typos.json. Change-Id: I6b787fcc3d6e7db2876f2a8d463125d4b8190644 --- M

[MediaWiki-commits] [Gerrit] Switch numbered link context to "delete" instead of "clear" - change (mediawiki...VisualEditor)

2015-12-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/257960 Change subject: Switch numbered link context to "delete" instead of "clear" .. Switch numbered link context to "delete" instead of "clear"

[MediaWiki-commits] [Gerrit] LinearDeleteKeyHandler: cope better with aliens - change (VisualEditor/VisualEditor)

2015-12-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/257041 Change subject: LinearDeleteKeyHandler: cope better with aliens .. LinearDeleteKeyHandler: cope better with aliens Expand the test suite so

[MediaWiki-commits] [Gerrit] Annotation context items: expand the selection if no annotat... - change (VisualEditor/VisualEditor)

2015-12-15 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/259216 Change subject: Annotation context items: expand the selection if no annotations .. Annotation context items: expand the selection if no

[MediaWiki-commits] [Gerrit] Fragment delete: handle a document with no valid content off... - change (VisualEditor/VisualEditor)

2015-12-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/258936 Change subject: Fragment delete: handle a document with no valid content offsets .. Fragment delete: handle a document with no valid content

[MediaWiki-commits] [Gerrit] ve.ce.minImgDataUri was considered invalid in Safari - change (VisualEditor/VisualEditor)

2016-01-06 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/262725 Change subject: ve.ce.minImgDataUri was considered invalid in Safari .. ve.ce.minImgDataUri was considered invalid in Safari ...so use a

[MediaWiki-commits] [Gerrit] Stop using broken image links in tests - change (mediawiki...VisualEditor)

2016-01-06 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/262847 Change subject: Stop using broken image links in tests .. Stop using broken image links in tests They make it a little bit more cluttered to

[MediaWiki-commits] [Gerrit] Initial cursor position: outside any nails - change (VisualEditor/VisualEditor)

2015-12-18 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/260057 Change subject: Initial cursor position: outside any nails .. Initial cursor position: outside any nails Place the initial cursor outside any

[MediaWiki-commits] [Gerrit] isBlockedTrigger should use meta+ for macs, not cmd+ - change (VisualEditor/VisualEditor)

2015-11-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/255474 Change subject: isBlockedTrigger should use meta+ for macs, not cmd+ .. isBlockedTrigger should use meta+ for macs, not cmd+ Change-Id:

[MediaWiki-commits] [Gerrit] Add cmd+[ / cmd+] as extra bindings for indent/outdent trigger - change (VisualEditor/VisualEditor)

2015-11-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/255482 Change subject: Add cmd+[ / cmd+] as extra bindings for indent/outdent trigger .. Add cmd+[ / cmd+] as extra bindings for indent/outdent

[MediaWiki-commits] [Gerrit] Collapse table selection when pressing escape - change (VisualEditor/VisualEditor)

2015-11-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/255494 Change subject: Collapse table selection when pressing escape .. Collapse table selection when pressing escape This only matters for merged

[MediaWiki-commits] [Gerrit] Change behavior of keydownhandler execution - change (VisualEditor/VisualEditor)

2015-11-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/255461 Change subject: Change behavior of keydownhandler execution .. Change behavior of keydownhandler execution Now returns whether it thinks it

[MediaWiki-commits] [Gerrit] When the cursor is inside a table cell, tab moves between cells - change (VisualEditor/VisualEditor)

2015-11-24 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/255160 Change subject: When the cursor is inside a table cell, tab moves between cells .. When the cursor is inside a table cell, tab moves between

[MediaWiki-commits] [Gerrit] Add ve.ce.Surface selectActiveLinkContents - change (VisualEditor/VisualEditor)

2015-11-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/254613 Change subject: Add ve.ce.Surface selectActiveLinkContents .. Add ve.ce.Surface selectActiveLinkContents Provides a way to force the

[MediaWiki-commits] [Gerrit] When adding a label to a numbered link, force the selection - change (mediawiki...VisualEditor)

2015-11-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/254615 Change subject: When adding a label to a numbered link, force the selection .. When adding a label to a numbered link, force the selection

[MediaWiki-commits] [Gerrit] Limit the height of fragment inspectors - change (VisualEditor/VisualEditor)

2015-11-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/254195 Change subject: Limit the height of fragment inspectors .. Limit the height of fragment inspectors Fragment inspectors can currently grow to

[MediaWiki-commits] [Gerrit] Decode encoded link titles when generating them from text - change (mediawiki...VisualEditor)

2016-06-08 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/293332 Change subject: Decode encoded link titles when generating them from text .. Decode encoded link titles when generating them from text

[MediaWiki-commits] [Gerrit] ProcessDialog: Change DOM ordering of actions - change (oojs/ui)

2016-06-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/293531 Change subject: ProcessDialog: Change DOM ordering of actions .. ProcessDialog: Change DOM ordering of actions Absolute positioning means

[MediaWiki-commits] [Gerrit] DesktopContext: Positioning a maybe-floated not-embeddable p... - change (VisualEditor/VisualEditor)

2016-06-15 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/294524 Change subject: DesktopContext: Positioning a maybe-floated not-embeddable popup .. DesktopContext: Positioning a maybe-floated not-embeddable

[MediaWiki-commits] [Gerrit] Links in focusableNodes: shouldn't look clickable - change (VisualEditor/VisualEditor)

2016-01-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/264098 Change subject: Links in focusableNodes: shouldn't look clickable .. Links in focusableNodes: shouldn't look clickable Not using

[MediaWiki-commits] [Gerrit] [WIP] Subdocuments: Current uses of Document are contained i... - change (VisualEditor/VisualEditor)

2016-02-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/269449 Change subject: [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet .. [WIP] Subdocuments: Current uses of Document

[MediaWiki-commits] [Gerrit] Don't just rely on jQuery width / height for hasRendering - change (VisualEditor/VisualEditor)

2016-02-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/268437 Change subject: Don't just rely on jQuery width / height for hasRendering .. Don't just rely on jQuery width / height for hasRendering jQuery

[MediaWiki-commits] [Gerrit] VE demo: allow saving some markup to localStorage for testing - change (VisualEditor/VisualEditor)

2016-02-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/268131 Change subject: VE demo: allow saving some markup to localStorage for testing .. VE demo: allow saving some markup to localStorage for testing

[MediaWiki-commits] [Gerrit] GeneratedContentNode: Check model existence before using - change (VisualEditor/VisualEditor)

2016-02-24 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/272999 Change subject: GeneratedContentNode: Check model existence before using .. GeneratedContentNode: Check model existence before using Hard to

[MediaWiki-commits] [Gerrit] oojs-ui.styles is now oojs-ui-core.styles - change (mediawiki...Vector)

2016-02-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/273931 Change subject: oojs-ui.styles is now oojs-ui-core.styles .. oojs-ui.styles is now oojs-ui-core.styles Bug: T127742 Change-Id:

[MediaWiki-commits] [Gerrit] MWMediaDialog: Only cache relevant information - change (mediawiki...VisualEditor)

2016-02-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/273923 Change subject: MWMediaDialog: Only cache relevant information .. MWMediaDialog: Only cache relevant information Trim the cached image data

[MediaWiki-commits] [Gerrit] Use throttle instead of debounce for find/replace rendering - change (VisualEditor/VisualEditor)

2016-02-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/273938 Change subject: Use throttle instead of debounce for find/replace rendering .. Use throttle instead of debounce for find/replace rendering

[MediaWiki-commits] [Gerrit] LinkContextItem: add a button to select the entire label - change (VisualEditor/VisualEditor)

2016-02-22 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/272510 Change subject: LinkContextItem: add a button to select the entire label .. LinkContextItem: add a button to select the entire label Adds a

[MediaWiki-commits] [Gerrit] Remove uses of plain .contentEditable - change (VisualEditor/VisualEditor)

2016-01-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/266265 Change subject: Remove uses of plain .contentEditable .. Remove uses of plain .contentEditable Browsers handle the inheritance via

[MediaWiki-commits] [Gerrit] AnnotationContextItem: refactor applying a change to the ann... - change (VisualEditor/VisualEditor)

2016-03-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/276517 Change subject: AnnotationContextItem: refactor applying a change to the annotation .. AnnotationContextItem: refactor applying a change to

[MediaWiki-commits] [Gerrit] Avoid error when cite is missing a templateName in the confi... - change (mediawiki...Citoid)

2016-04-05 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/281691 Change subject: Avoid error when cite is missing a templateName in the config map .. Avoid error when cite is missing a templateName in the

[MediaWiki-commits] [Gerrit] ve.ui.TabbableElements: JS replacement for unreliable tabIndex - change (VisualEditor/VisualEditor)

2016-04-12 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/282964 Change subject: ve.ui.TabbableElements: JS replacement for unreliable tabIndex .. ve.ui.TabbableElements: JS replacement for unreliable

[MediaWiki-commits] [Gerrit] LinkAnnotationInspector: add a button to edit the label - change (VisualEditor/VisualEditor)

2016-03-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/278284 Change subject: LinkAnnotationInspector: add a button to edit the label .. LinkAnnotationInspector: add a button to edit the label Adds a

[MediaWiki-commits] [Gerrit] Template Dialog: pushPending while the dialog is closing - change (mediawiki...VisualEditor)

2016-03-24 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/279387 Change subject: Template Dialog: pushPending while the dialog is closing .. Template Dialog: pushPending while the dialog is closing

[MediaWiki-commits] [Gerrit] LinearArrowKeyDownHandler: test more - change (VisualEditor/VisualEditor)

2016-03-23 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/279134 Change subject: LinearArrowKeyDownHandler: test more .. LinearArrowKeyDownHandler: test more Bug: T130389 Change-Id:

[MediaWiki-commits] [Gerrit] core: Add tests for throttle - change (oojs/ui)

2016-03-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/278027 Change subject: core: Add tests for throttle .. core: Add tests for throttle Change-Id: Ifaae9899b020848afa07d455347c8b06f114ba14 --- M

[MediaWiki-commits] [Gerrit] FindAndReplaceDialog: don't use tabindex - change (VisualEditor/VisualEditor)

2016-03-02 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/274453 Change subject: FindAndReplaceDialog: don't use tabindex .. FindAndReplaceDialog: don't use tabindex `tabindex is a global attribute. Letting

[MediaWiki-commits] [Gerrit] Dialog: trigger the primary action with ctrl-enter - change (oojs/ui)

2016-03-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/274984 Change subject: Dialog: trigger the primary action with ctrl-enter .. Dialog: trigger the primary action with ctrl-enter If a dialog has

[MediaWiki-commits] [Gerrit] FocusableNode: forcibly update the active link on click - change (VisualEditor/VisualEditor)

2016-03-01 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/274145 Change subject: FocusableNode: forcibly update the active link on click .. FocusableNode: forcibly update the active link on click Selecting

[MediaWiki-commits] [Gerrit] Add throttle to complement debounce - change (oojs/ui)

2016-03-08 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/275913 Change subject: Add throttle to complement debounce .. Add throttle to complement debounce Change-Id:

[MediaWiki-commits] [Gerrit] LinearArrowKeyDownHandler: more tests - change (VisualEditor/VisualEditor)

2016-03-31 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/280677 Change subject: LinearArrowKeyDownHandler: more tests .. LinearArrowKeyDownHandler: more tests Bug: T130389 Change-Id:

[MediaWiki-commits] [Gerrit] [Failing] Test cases for cursoring off focused block nodes w... - change (VisualEditor/VisualEditor)

2016-03-31 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/280680 Change subject: [Failing] Test cases for cursoring off focused block nodes with shift .. [Failing] Test cases for cursoring off focused block

[MediaWiki-commits] [Gerrit] MWLinkAnnotationInspector: select entire link when switching... - change (mediawiki...VisualEditor)

2016-03-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/279961 Change subject: MWLinkAnnotationInspector: select entire link when switching tabs .. MWLinkAnnotationInspector: select entire link when

[MediaWiki-commits] [Gerrit] Use "publish" instead of "save" in toolbar and save-dialog - change (mediawiki...VisualEditor)

2016-04-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/281462 Change subject: Use "publish" instead of "save" in toolbar and save-dialog .. Use "publish" instead of "save" in toolbar and save-dialog Bug:

[MediaWiki-commits] [Gerrit] Give the active link annotation inline-block - change (VisualEditor/VisualEditor)

2016-04-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/281456 Change subject: Give the active link annotation inline-block .. Give the active link annotation inline-block This fixes an issue where

[MediaWiki-commits] [Gerrit] Dialog: When reusing a reference, avoid popping up the group... - change (mediawiki...Cite)

2016-04-26 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/285421 Change subject: Dialog: When reusing a reference, avoid popping up the group menu .. Dialog: When reusing a reference, avoid popping up the

[MediaWiki-commits] [Gerrit] Insert undo breakpoints at word breaks - change (VisualEditor/VisualEditor)

2016-05-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/287972 Change subject: Insert undo breakpoints at word breaks .. Insert undo breakpoints at word breaks When users interact with the contenteditable

[MediaWiki-commits] [Gerrit] ce.Surface: Convenience function for selecting node contents - change (VisualEditor/VisualEditor)

2016-04-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/284221 Change subject: ce.Surface: Convenience function for selecting node contents .. ce.Surface: Convenience function for selecting node contents

[MediaWiki-commits] [Gerrit] Select the label properly when converting LinkNode to LinkAn... - change (mediawiki...VisualEditor)

2016-04-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/284223 Change subject: Select the label properly when converting LinkNode to LinkAnnotation .. Select the label properly when converting LinkNode to

[MediaWiki-commits] [Gerrit] OutlineOptionWidget mediawiki theme: icons the correct size - change (oojs/ui)

2016-04-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/284481 Change subject: OutlineOptionWidget mediawiki theme: icons the correct size .. OutlineOptionWidget mediawiki theme: icons the correct size

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWLinkAnnotationInspector: change where auto switch to exter...

2016-07-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/301629 Change subject: MWLinkAnnotationInspector: change where auto switch to external occurs .. MWLinkAnnotationInspector: change where auto switch

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Centralize some checks for unmodified left clicks

2016-08-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/304280 Change subject: Centralize some checks for unmodified left clicks .. Centralize some checks for unmodified left clicks Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (f1fa096)

2016-08-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/304313 Change subject: Update VE core submodule to master (f1fa096) .. Update VE core submodule to master (f1fa096) New changes: a3ca325 Use OO.ui

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Use OO.ui constants for mouse buttons

2016-08-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/304279 Change subject: Use OO.ui constants for mouse buttons .. Use OO.ui constants for mouse buttons Also adds a helper for checking whether a

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: BranchNote: make block slug contenteditable=false

2016-08-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/303820 Change subject: BranchNote: make block slug contenteditable=false .. BranchNote: make block slug contenteditable=false It's possible to

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: LinkAnnotationInspector: add a "label" field

2016-08-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/303956 Change subject: LinkAnnotationInspector: add a "label" field .. LinkAnnotationInspector: add a "label" field This field will allow the link

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: Dialog must listen for changes to the param names

2016-08-12 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/304594 Change subject: Dialog must listen for changes to the param names .. Dialog must listen for changes to the param names Otherwise the second

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ce.Surface: when setting selection just focus if focusTar...

2016-08-12 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/304575 Change subject: ve.ce.Surface: when setting selection just focus if focusTarget == activeElement .. ve.ce.Surface: when setting selection

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: Flag the help button as progressive

2016-08-12 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/304487 Change subject: Flag the help button as progressive .. Flag the help button as progressive This gives it visual indicators that it'll take

[MediaWiki-commits] [Gerrit] TabIndexScope: skipAriaHidden not respected, and applied to ... - change (VisualEditor/VisualEditor)

2016-07-21 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/300309 Change subject: TabIndexScope: skipAriaHidden not respected, and applied to FragmentDialog .. TabIndexScope: skipAriaHidden not respected,

[MediaWiki-commits] [Gerrit] MWSaveDialog: Give checkboxes a class based on their origin'... - change (mediawiki...VisualEditor)

2016-07-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/299779 Change subject: MWSaveDialog: Give checkboxes a class based on their origin's name .. MWSaveDialog: Give checkboxes a class based on their

[MediaWiki-commits] [Gerrit] Move internal-link detection into the InternalLinkAnnotation... - change (mediawiki...VisualEditor)

2016-07-15 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/299190 Change subject: Move internal-link detection into the InternalLinkAnnotationWidget .. Move internal-link detection into the

[MediaWiki-commits] [Gerrit] TabIndexScope: respect aria-hidden - change (VisualEditor/VisualEditor)

2016-07-07 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/297804 Change subject: TabIndexScope: respect aria-hidden .. TabIndexScope: respect aria-hidden Bug: T129792 Bug: T129791 Change-Id:

[MediaWiki-commits] [Gerrit] Window: make the focus trap smarter - change (oojs/ui)

2016-07-06 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/297608 Change subject: Window: make the focus trap smarter .. Window: make the focus trap smarter Current behavior will always focus the content

[MediaWiki-commits] [Gerrit] TitleOptionWidget: don't subvert OptionWidget's tabindex - change (mediawiki/core)

2016-07-05 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/297424 Change subject: TitleOptionWidget: don't subvert OptionWidget's tabindex .. TitleOptionWidget: don't subvert OptionWidget's tabindex

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.Surface: only change selection during CleanupUnicorns if ...

2016-08-07 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/303505 Change subject: ce.Surface: only change selection during CleanupUnicorns if it's in the document .. ce.Surface: only change selection during

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Dialog: meta as well as ctrl for modifier on enter

2017-01-31 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335257 ) Change subject: Dialog: meta as well as ctrl for modifier on enter .. Dialog: meta as well as ctrl for modifier on enter This is consistent

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget: wait for global.js as well

2017-02-01 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335462 ) Change subject: DesktopArticleTarget: wait for global.js as well .. DesktopArticleTarget: wait for global.js as well Bug: T156899

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ArticleTarget: try to refresh editToken if getWikitextFragme...

2017-02-07 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336439 ) Change subject: ArticleTarget: try to refresh editToken if getWikitextFragment fails .. ArticleTarget: try to refresh editToken if

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DatetimeAnnotation: flesh out model with datetime attribute

2017-01-23 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333666 ) Change subject: DatetimeAnnotation: flesh out model with datetime attribute .. DatetimeAnnotation: flesh out model with datetime attribute

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWSaveDialog: only focus summary if we're on the save panel

2017-01-26 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334373 ) Change subject: MWSaveDialog: only focus summary if we're on the save panel .. MWSaveDialog: only focus summary if we're on the save panel

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Advanced Settings: prefill current page title when enabling ...

2017-01-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334151 ) Change subject: Advanced Settings: prefill current page title when enabling displaytitle .. Advanced Settings: prefill current page title

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget.init: Don't hardcode single-tab accesskey

2017-02-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337610 ) Change subject: DesktopArticleTarget.init: Don't hardcode single-tab accesskey .. DesktopArticleTarget.init: Don't hardcode single-tab

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ui.Surface: fix issues with scrolling while selection

2017-02-09 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336844 ) Change subject: ve.ui.Surface: fix issues with scrolling while selection .. ve.ui.Surface: fix issues with scrolling while selection Rely

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWSaveDialog: Switch to save panel when showing message

2017-02-16 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338134 ) Change subject: MWSaveDialog: Switch to save panel when showing message .. MWSaveDialog: Switch to save panel when showing message Fixing

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: init: port in isUnModifiedLeftClick without any VE core depe...

2016-08-22 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/306044 Change subject: init: port in isUnModifiedLeftClick without any VE core dependencies .. init: port in isUnModifiedLeftClick without any VE

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: init: Don't set an invalid progress state when loading

2016-08-23 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/306240 Change subject: init: Don't set an invalid progress state when loading .. init: Don't set an invalid progress state when loading Bug: T143160

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: getNodeAndOffset: check whether the node has a view before u...

2016-08-30 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/307533 Change subject: getNodeAndOffset: check whether the node has a view before using it .. getNodeAndOffset: check whether the node has a view

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.TableRowNode: check we're still attached in setupMissingCell

2016-08-31 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/307782 Change subject: ce.TableRowNode: check we're still attached in setupMissingCell .. ce.TableRowNode: check we're still attached in

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: TableKeyDownHandler: return early if any modifier other than...

2016-09-08 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/309352 Change subject: TableKeyDownHandler: return early if any modifier other than shift is used .. TableKeyDownHandler: return early if any

[MediaWiki-commits] [Gerrit] mediawiki...Citoid[master]: Decode likely URLs before sending them to citoid

2016-09-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. https://gerrit.wikimedia.org/r/313428 Change subject: Decode likely URLs before sending them to citoid .. Decode likely URLs before sending them to citoid The citoid service seems

  1   2   3   >