Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
panbingkun commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2097081735 > cc @panbingkun as well. Got it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
dongjoon-hyun commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2096858566 Thank you, @gengliangwang . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
dongjoon-hyun commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2096858225 Merged to master for Apache Spark 4.0.0-preview. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
dongjoon-hyun closed pull request #46405: [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework URL: https://github.com/apache/spark/pull/46405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
dongjoon-hyun commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2096823556 cc @cloud-fan as a release manager for Apache Spark 4.0.0-preview -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
gengliangwang commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2096804422 In Scala side, the logDebug/logTrace APIs was introduced for debugging cache purposes: https://github.com/apache/spark/pull/45990 -- This is an automated message from the Apache

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
gengliangwang commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2096798820 > Is this consistent with SPIP, @gengliangwang ? Yes, the SPIP only suggests the logInfo/logWarn/logError APIs. LogDebug/LogTrace is optional. Since

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
dongjoon-hyun commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2096743623 #46390 is not merged yet, isn't it? > In the log migration PR https://github.com/apache/spark/pull/46390, there are unnecessary changes such as updating -- This is an

Re: [PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
gengliangwang commented on PR #46405: URL: https://github.com/apache/spark/pull/46405#issuecomment-2096695524 cc @panbingkun as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [SPARK-48145][CORE] Remove logDebug and logTrace with MDC in JAVA structured logging framework [spark]

2024-05-06 Thread via GitHub
gengliangwang opened a new pull request, #46405: URL: https://github.com/apache/spark/pull/46405 ### What changes were proposed in this pull request? Since we are targeting on migration INFO/WARN/ERROR level logs to structure logging, this PR removes the logDebug and logTrace