new patch

On 4/26/07, Matthias Wessendorf <[EMAIL PROTECTED]> wrote:
On 4/26/07, Adam Winer <[EMAIL PROTECTED]> wrote:
> I'm confused about this patch:
>
> -       if(this._isConvertible())
> +       if(!(numberString.indexOf(',') != -1 || numberString.indexOf(',') !=
> -1) && this._isConvertible())
>         {
>                 return _decimalParse(numberString,
>                           this._messages,
>
> Why is numberString.indexOf(',') != -1 being checked twice?

typo ...

'.' and ','
> And, if you're trying to use the numeric separator, shouldn't
> this be localized, not a hardcoded character?

yes, I'll check that as well

>
> -- Adam
>
>
> On 4/26/07, Matthias Wessendorf <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > there is a minimalistic version of the client side converter for the
> > NumberConverter, but this client side converter is causing some
> > issues. There might be some *tool* that help us (me) to get a better
> > version. However, does anyone mind to apply the patch for
> >
> > https://issues.apache.org/jira/browse/ADFFACES-468
> >
> > in the mean time ?
> > (it's only a subtask of a bug, saying, we need a client side number 
converter)
> >
> > -M
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>


--
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com



--
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Reply via email to