On 02/22/2018 06:43 PM, Luke Shumaker wrote:
> On Thu, 22 Feb 2018 16:43:36 -0500,
> Eli Schwartz wrote:
>>> __getCheckSum() {
>>> - local result=($(sha1sum $1))
>>> - echo ${result[0]}
>>> + local result
>>> + result="$(sha1sum "$1")"
>>> + echo "${result%% *}"
>>
>> Why are you moving over to declaring the variable and assigning it on
>> different lines?
>
> Because shellcheck complains about it, so it's a habit I've gotten in
> to :) Even in cases where it doesn't really make a difference.
>
> https://github.com/koalaman/shellcheck/wiki/SC2155
>
> However, BATS does run the test suite with `set -e`, so splitting it
> does mean that BATS will now detect errors from sha1sum. We don't
> really expect that to happen, but if BATS will give us error checking
> on it for free, why not?Then the commit message should say so... -- Eli Schwartz Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
