-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3375/
-----------------------------------------------------------
(Updated March 24, 2014, 9:31 a.m.)
Review request for Asterisk Developers.
Changes
-------
Minor cleanups. The check for text column moved to a separate inline function.
Bugs: ASTERISK-23459
https://issues.asterisk.org/jira/browse/ASTERISK-23459
Repository: Asterisk
Description
-------
This review request is a patch for the issue reviewed in
https://reviewboard.asterisk.org/r/3335 but for non-trunk versions.
Changes:
- correct check for keyfield existence,
- new res_odbc.conf variable allow_empty_string_in_nontext,
- proper empty string => NULL conversion with allow_empty_string_in_nontext
option disabled
for non-text columns.
This patch is based on branch 11 svn, but code for 1.8 and 10 is the same, so
it should apply with no problems.
Diffs (updated)
-----
http://svn.asterisk.org/svn/asterisk/branches/11/res/res_odbc.exports.in
411017
http://svn.asterisk.org/svn/asterisk/branches/11/res/res_odbc.c 411017
http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c 411017
http://svn.asterisk.org/svn/asterisk/branches/11/include/asterisk/res_odbc.h
411017
http://svn.asterisk.org/svn/asterisk/branches/11/configs/res_odbc.conf.sample
411017
Diff: https://reviewboard.asterisk.org/r/3375/diff/
Testing
-------
Tested with Asterisk 11 + ODBC + SIP realtime + PostgreSQL with both
allow_empty_string_in_nontext settings
to ensure no regression is introduced.
Thanks,
zvision
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
