----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3337/#review11353 -----------------------------------------------------------
http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_asterisk.c <https://reviewboard.asterisk.org/r/3337/#comment20988> Coding guidelines: Opening brace goes on the same line as the if. http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_asterisk.c <https://reviewboard.asterisk.org/r/3337/#comment20991> There is a race condition here where multiple timeouts could be setup if the timer callback is running when dtls_srtp_check_pending is called from outside the timer callback. When this happens, the AST_SCHED_DEL_UNREF attempt will instead have to use ast_sched_del to check for failure and abort rescheduling for one of the call paths (timer->dtls_srtp_check_pending or other_code->dtls_srtp_check_pending) since the other code path will need to go ahead with the rescheduling attempt. http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_asterisk.c <https://reviewboard.asterisk.org/r/3337/#comment20992> Coding guidelines. http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_asterisk.c <https://reviewboard.asterisk.org/r/3337/#comment20993> Coding guidelines. http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_asterisk.c <https://reviewboard.asterisk.org/r/3337/#comment20994> Coding guidelines. - opticron On March 12, 2014, 8:21 a.m., Nitesh Bansal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3337/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 8:21 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This patch adds the code to do the DTLS retransmissions in Asterisk. > > > Diffs > ----- > > http://svn.asterisk.org/svn/asterisk/branches/11/res/res_rtp_asterisk.c > 410469 > > Diff: https://reviewboard.asterisk.org/r/3337/diff/ > > > Testing > ------- > > I tested this with a basic SIPP script, which fakes a DTLS INVITE. > Asterisk thinks that it is a DTLS call and inititates the DTLS handshake. > SIPP doesn't respond to DTLS handshake, which causes the DTLS timeout and > DTLS retransmission takes place. > > > Thanks, > > Nitesh Bansal > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
