On Sun, 18 May 2014 14:10:50 +0100 Tristan Wibberley <tristan.wibber...@gmail.com> wrote:
> Currently, make completion will parse the output of $(info ...) looking for > make targets. It's too easy to cause extra targets to be suggested by > accident. This patch makes completion ignore lines that appear before the > database output begins. Hi Tristan. Thank you for the patch. Could you please also modify the following Makefile to make the bash-completion testsuite fail without the patch: https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=bash-completion/bash-completion.git;a=blob;f=test/fixtures/make/Makefile;hb=HEAD ? -- Igor > --- > completions/make | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/completions/make b/completions/make > index b6683b8..f8f7193 100644 > --- a/completions/make > +++ b/completions/make > @@ -20,7 +20,7 @@ function _make_target_extract_script() > fi > > cat <<EOF > - /^# Make data base/,/^# Files/d; # skip until files section > + 1,/^# Files/ d; # skip until files section > /^# Not a target/,/^$/ d; # skip not target blocks > /^${prefix_pat}/,/^$/! d; # skip anything user dont > want > > -- > 1.9.1 _______________________________________________ Bash-completion-devel mailing list Bash-completion-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/bash-completion-devel