On Wed, Dec 16, 2015 at 5:21 AM, Liuhua Wang <lw...@suse.com> wrote: > There are the following problems with lvm completions:
Thanks for the patch and sorry about the delay. I don't use lvm myself -- any lvm users around to review this? In any case, please add test cases for the changes to the extent it makes sense (and make sure they're properly skipped or fail gracefully on non-lvm systems). Also, your change appears to cover three changes, would be better to split the change to three different commits (again if it's sanely doable), each doing one thing. _______________________________________________ Bash-completion-devel mailing list Bash-completion-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/bash-completion-devel