LGTM3 On Thu, Nov 23, 2023 at 1:44 AM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM2 > On 11/22/23 11:15 AM, Yoav Weiss wrote: > > LGTM1 > > On Thursday, November 9, 2023 at 7:05:57 PM UTC+1 Vladimir Levin wrote: > > > > On Thu, Nov 9, 2023, 12:54 Mike Taylor <miketa...@chromium.org> wrote: > > On 11/8/23 3:53 PM, Vladimir Levin wrote: > > Contact emails vmp...@chromium.org, nrosent...@chromium.org > > Explainer https://github.com/vmpstr/web-proposals/blob/main/ > explainers/view-transition-types.md > > Specification https://drafts.csswg.org/css-view-transitions-2/#the- > active-view-transition-pseudo > > Summary > > This feature allows View transition API use to be customized for different > types of transitions. Specifically, this adds an ability to add "types" to > `startViewTransition` call which will identify the types of the transition. > As well, it will match a pseudo-class, called `:active-view-transitions(...)` > with a parameter matching the type for the duration of the view transition. > Combined these two features provide a way for the author to declare several > view transitions once and only trigger one at a time. See example usage in > the spec: https://drafts.csswg.org/css-view-transitions-2/#the- > active-view-transition-pseudo > > Blink component Blink>ViewTransitions>SPA > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EViewTransitions%3ESPA> > > TAG review https://github.com/w3ctag/design-reviews/issues/908 > > TAG review status Pending > > Risks > > > Interoperability and Compatibility > > There are minimal interop and copmat risks. This feature is an extension > to the View Transitions API that makes it more ergonomic to specify > multiple transitions declaratively, while triggering only one of them at a > time. > > > *Gecko*: No signal (https://github.com/mozilla/ > standards-positions/issues/905) > > > Gecko are now positive! > > > *WebKit*: No signal (https://github.com/WebKit/ > standards-positions/issues/266) > > *Web developers*: No (strong) signals, the feature request came from a > web developer: https://github.com/w3c/csswg-drafts/issues/8960 > > *Other signals*: > > Ergonomics > > This feature would be used with the View Transitions API to be able to > easier maintain a declarative set of multiple transitions that can be > triggered. This solution uses a descendant combinator heavily to > selectively style elements in the DOM, but this is not any different from > the polyfill approach of toggling a class on :root. > > > Activation > > This feature can be used directly and fairly easily. > > > Security > > There are no additional security considerations over the View Transitions > API. > > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > None > > > Debuggability > > This feature is debuggable in the same way as the View Transitions API, > and also in the same way as other CSS properties. > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, Chrome OS, Android, and Android WebView)? Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ? No > > Any reason why? > > > Oops, that should say "Yes". I'll update chromestatus > > > Flag name on chrome://flags ViewTransitionTypes > > Finch feature name ViewTransitionTypes > > Requires code in //chrome? False > > Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1466251 > > Estimated milestones Shipping on desktop 121 Shipping on Android 121 Shipping > on WebView 121 > > Anticipated spec changes > > Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way). > None > > Link to entry on the Chrome Platform Status https://chromestatus.com/ > feature/5089552511533056 > > Links to previous Intent discussions Intent to prototype: https://groups. > google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2NjgR_%2BTbJbU5O% > 2BiyhnqxypDAUh7LWHUCWy%3DNnaBCY%2B1g%40mail.gmail.com > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit https://groups.google.com/a/ > chromium.org/d/msgid/blink-dev/CADsXd2PckO%3DXSq8HDCy4foC_ > Xj3Nh3dBxzSCkZ5GEyD%2BjdMcFQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2PckO%3DXSq8HDCy4foC_Xj3Nh3dBxzSCkZ5GEyD%2BjdMcFQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > > To view this discussion on the web visit https://groups.google.com/a/ > chromium.org/d/msgid/blink-dev/83c2931c-d242-4ce1-bc35- > b8af8a6824f3%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/83c2931c-d242-4ce1-bc35-b8af8a6824f3%40chromium.org?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/29402b68-455f-402c-957a-b57b2ecc1334%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/29402b68-455f-402c-957a-b57b2ecc1334%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-dUe8TbKfJ%3DCg5YsWcAEyb67yHp13L_F2XqTeSqvw8QA%40mail.gmail.com.