On 02/02/2023 19:59, Petr Machata wrote: > The following patch will add two more maximum MDB allowances to the global > one, mcast_hash_max, that exists today. In all these cases, attempts to add > MDB entries above the configured maximums through netlink, fail noisily and > obviously. Such visibility is missing when adding entries through the > control plane traffic, by IGMP or MLD packets. > > To improve visibility in those cases, add a trace point that reports the > violation, including the relevant netdevice (be it a slave or the bridge > itself), and the MDB entry parameters: > > # perf record -e bridge:br_mdb_full & > # [...] > # perf script | cut -d: -f4- > dev v2 af 2 src ::ffff:0.0.0.0 grp > ::ffff:239.1.1.112/00:00:00:00:00:00 vid 0 > dev v2 af 10 src :: grp ff0e::112/00:00:00:00:00:00 vid 0 > dev v2 af 2 src ::ffff:0.0.0.0 grp > ::ffff:239.1.1.112/00:00:00:00:00:00 vid 10 > dev v2 af 10 src 2001:db8:1::1 grp ff0e::1/00:00:00:00:00:00 vid 10 > dev v2 af 2 src ::ffff:192.0.2.1 grp > ::ffff:239.1.1.1/00:00:00:00:00:00 vid 10 > > CC: Steven Rostedt <rost...@goodmis.org> > CC: linux-trace-ker...@vger.kernel.org > Signed-off-by: Petr Machata <pe...@nvidia.com> > Reviewed-by: Steven Rostedt (Google) <rost...@goodmis.org> > --- > > Notes: > v2: > - Report IPv4 as an IPv6-mapped address through the IPv6 buffer > as well, to save ring buffer space. > > include/trace/events/bridge.h | 58 +++++++++++++++++++++++++++++++++++ > net/core/net-traces.c | 1 + > 2 files changed, 59 insertions(+) >
Acked-by: Nikolay Aleksandrov <ra...@blackwall.org>
