On Wed, 2 Dec 2020 20:01:08 GMT, Tim Bell <tb...@openjdk.org> wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added test > > test/make/TestFixDepsFile.gmk line 60: > >> 58: $(ECHO) " $(WORKSPACE_ROOT)/bar/baz \\" >> $(DEPS_FILE).expected >> 59: $(ECHO) " /foo/baz" >> $(DEPS_FILE).expected >> 60: $(DIFF) $(DEPS_FILE).expected $(DEPS_FILE) > > Does this need to be: > $(DIFF) $(DEPS_FILE).expected $(DEPS_FILE).tmp
No, the fix-deps-file macro takes file.tmp as input and outputs into file, so $(DEPS_FILE) is the output file from the macro in this case. ------------- PR: https://git.openjdk.java.net/jdk/pull/1548
