On Fri, 4 Aug 2023 11:17:43 GMT, Andreas Steiner <d...@openjdk.org> wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is >> equivalent to the other used tools flags like AR. >> This change will replace the quick fix done in >> https://bugs.openjdk.org/browse/JDK-8312466. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > remove needless else make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid the flag there? flags-other.m4 : the comment 'on AIX ...' is just stating the obvious; maybe it should better mention that without -X64 we only process 32bit objects ('Processes only 32-bit object files' says the manpage , and this is the default on AIX) ; or avoid the comment altogether ? ------------- PR Review: https://git.openjdk.org/jdk/pull/15150#pullrequestreview-1562785813
