dmgreen added inline comments.
================ Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>, SDTCisSameNumEltsAs<0, 1> ---------------- bsmith wrote: > dmgreen wrote: > > Is this used? The one above should maybe say `// fpround`? > No it's not, I added it for consistency, but perhaps I shouldn't? I think > fround is correct for the one above, or at least is consistent with the > others in this file, for example fextend below. It's used below in `def fpround : SDNode<"ISD::FP_ROUND" , SDTFPRoundOp>;`, so it looks like its used with the fptrunc instruction, not the fround intrinsic. I see your point about fextend... I would say they should both be changed to fpextend/fpround, for consistency with the nodes they act upon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98487/new/ https://reviews.llvm.org/D98487 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
