MaskRay added inline comments.
================ Comment at: llvm/include/llvm/Support/TargetRegistry.h:26 #include "llvm/ADT/iterator_range.h" +#include "llvm/MC/MCObjectFileInfo.h" #include "llvm/Support/CodeGen.h" ---------------- `include/llvm/Support/TargetRegistry.h now has cyclic dependency on include/MC/*.h`. The previous style isn't good as well: `include/llvm/Support/TargetRegistry.h` has forward declarations of a number of MC* classes. I think this header probably should be moved to lib/Target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101921/new/ https://reviews.llvm.org/D101921 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
