mizvekov added a comment. @rsmith what do you think of the following strategy as a follow up to this patch:
- First step we replace the assert at line 7866 with a `deleted` result. I don't really think it's sustainable to keep returning incorrect results / crashing for builtin types that are to be supported in the future. We create a new diagnostic for unimplemented builtin type for three-way comparison or something along these lines. This will gloss over for now function pointers, the only other type which we are adding to the candidate set which we should not be doing. As a consequence, we produce slightly unhelpful diagnostics here, for now. - Second step we modify `AddTypesConvertedFrom` so it can ignore function pointers, when used for purposes of building a candidate set for three-way comparison. Here, we would correct the diagnostics from step one. Thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103760/new/ https://reviews.llvm.org/D103760 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
