[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

[Leonard Chan via Phabricator via cfe-commits]

leonardchan created this revision.
leonardchan added reviewers: eugenis, vitalybuka.
leonardchan added a project: Sanitizers.
Herald added a subscriber: dberris.
leonardchan requested review of this revision.
Herald added a subscriber: Sanitizers.

This is mostly a stylistic preference. Currently all the frame records are 
dumped on one line (`record:0xb8b4214178819a54{{{bt:0:0x214178819a54}}}  
record_addr:0x22c8777bdb08 record:0xb8e0214178818394{{{bt:0:0x2141788183...`) 
but it might be easier to debug if it we newline-separated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103845

Files:
  compiler-rt/lib/hwasan/hwasan_report.cpp


Index: compiler-rt/lib/hwasan/hwasan_report.cpp
===================================================================
--- compiler-rt/lib/hwasan/hwasan_report.cpp
+++ compiler-rt/lib/hwasan/hwasan_report.cpp
@@ -240,6 +240,8 @@
                   common_flags()->symbolize_vs_style,
                   common_flags()->strip_path_prefix);
       frame->ClearAll();
+    } else {
+      frame_desc.append("\n");
     }
     Printf("%s", frame_desc.data());
     frame_desc.clear();



Index: compiler-rt/lib/hwasan/hwasan_report.cpp
===================================================================
--- compiler-rt/lib/hwasan/hwasan_report.cpp
+++ compiler-rt/lib/hwasan/hwasan_report.cpp
@@ -240,6 +240,8 @@
                   common_flags()->symbolize_vs_style,
                   common_flags()->strip_path_prefix);
       frame->ClearAll();
+    } else {
+      frame_desc.append("\n");
     }
     Printf("%s", frame_desc.data());
     frame_desc.clear();

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits