On Mon, Jun 14, 2021 at 4:52 PM Wei Mi <w...@google.com> wrote: > > > On Mon, Jun 14, 2021 at 4:04 PM Xinliang David Li <davi...@google.com> > wrote: > >> >> >> On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> lebedev.ri added a subscriber: MaskRay. >>> lebedev.ri added a comment. >>> >>> In D104099#2815531 <https://reviews.llvm.org/D104099#2815531>, @wenlei >>> wrote: >>> >>> > In D104099#2814167 <https://reviews.llvm.org/D104099#2814167>, >>> @davidxl wrote: >>> > >>> >> Adding Wei to help measure performance impact on our internal >>> workloads. Also add Wenlei to help measure impact with FB's workloads. >>> > >>> > Measured perf using FB internal workload w/ and w/o this pass, result >>> is neutral. >>> >>> Thank you for checking! >>> >>> So far, it seems the reaction to this proposal has been overwhelmingly >>> positive. >>> Does anyone else wish to chime in? Should i land this? @asbirlea >>> @MaskRay ? >>> >> >> Wei is doing more measurement @google. Please wait for the response. >> >> David >> > > Start doing the test. Will report back. > > Wei. >
No performance change found in google internal benchmarks. Wei. > > >> >> >>> >>> Repository: >>> rG LLVM Github Monorepo >>> >>> CHANGES SINCE LAST ACTION >>> https://reviews.llvm.org/D104099/new/ >>> >>> https://reviews.llvm.org/D104099 >>> >>>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
