RedDocMD added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:217 + if (&BR.getBugType() != smartptr::getNullDereferenceBugType() || + !BR.isInteresting(FirstArgThisRegion)) + return; ---------------- vsavchenko wrote: > Wait, and what if the second argument is interesting? I know. That's why I said that the note is crappy. The question I have in mind is - what if we swap null with null? Do we want a note in that case? IMO, we should have a note for every case of swapping a //confirmed// null with something that is //not// confirmed to be null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
