jsji added a comment.

> The default Altivec ABI was implemented

Please include the patches or commits that implement the default ABI.



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4779
       CmdArgs.push_back("-mabi=vec-extabi");
+    else if (A->getOption().getID() == options::OPT_mabi_EQ_vec_default)
+      CmdArgs.push_back("-mabi=vec-default");
----------------
Why we need to check this if the default is to set it to `-mabi=vec-default` in 
below else?


================
Comment at: clang/test/Driver/aix-vec-extabi.c:11
+// DFLTABI-SAME: "-mabi=vec-default"
+// DFLTABI-NOT:  "-mabi=vec-default"
----------------
Why we need to explicitly `DFLTABI-NOT:  "-mabi=vec-default"`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102094/new/

https://reviews.llvm.org/D102094

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to